From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161922AbcFHJGi (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jun 2016 05:06:38 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:34420 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1423148AbcFHJGY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jun 2016 05:06:24 -0400
Date: Wed, 8 Jun 2016 11:06:20 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        "H. Peter Anvin" <hpa@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@amacapital.net>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly
 outputs
Message-ID: <20160608090620.GA11451@gmail.com>
References: <1465342269-492350-1-git-send-email-hpa@linux.intel.com>
 <1465342269-492350-3-git-send-email-hpa@linux.intel.com>
 <20160608074956.GO30154@twins.programming.kicks-ass.net>
 <20160608082835.GB9645@gmail.com>
 <2074cf4f-2074-98be-809f-3bc33db8169a@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2074cf4f-2074-98be-809f-3bc33db8169a@zytor.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 06/08/16 01:28, Ingo Molnar wrote:
> > 
> > It does matter:
> > 
> >  In file included from arch/x86/kernel/cpu/common.c:21:0:
> >  ./arch/x86/include/asm/archrandom.h:95:20: error: redefinition of ‘arch_get_random_long’
> >  static inline bool arch_get_random_long(unsigned long *v)
> >  In file included from ./arch/x86/include/asm/stackprotector.h:43:0,
> >  include/linux/random.h:98:20: note: previous definition of ‘arch_get_random_long’ was here
> > 
> 
> Actually this is an indication of a major bug, quite possibly
> pre-existing; we somehow are trying to include both the stub and the
> non-stub version of arch_get_random_long(), which is an obvious no-no.

Yeah.

> I will look at it in the morning (02:00 here.)

Sure, take your time! I've rewinded x86/asm to 08dd8cd06ed9 for the time being.

Thanks,

	Ingo