From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423853AbcFHJ33 (ORCPT ); Wed, 8 Jun 2016 05:29:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:46263 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423658AbcFHJ30 (ORCPT ); Wed, 8 Jun 2016 05:29:26 -0400 From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu , linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli , Brendan Gregg Subject: [PATCH perf/core v10 02/23] perf-probe: Fix to add NULL check for strndup Date: Wed, 8 Jun 2016 18:29:21 +0900 Message-Id: <20160608092920.3116.63319.stgit@devbox> X-Mailer: git-send-email 2.1.0 In-Reply-To: <20160608092854.3116.29007.stgit@devbox> References: <20160608092854.3116.29007.stgit@devbox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to add a NULL check for strndup when parsing probe trace command. Signed-off-by: Masami Hiramatsu --- Changes in v10: - Splited from "perf probe: Allow wildcard for cached events" --- tools/perf/util/probe-event.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 74401a2..7ae3dd1 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -1603,6 +1603,10 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev) p = strchr(argv[1], ':'); if (p) { tp->module = strndup(argv[1], p - argv[1]); + if (!tp->module) { + ret = -ENOMEM; + goto out; + } p++; } else p = argv[1];