From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424471AbcFHKKE (ORCPT ); Wed, 8 Jun 2016 06:10:04 -0400 Received: from outbound-smtp11.blacknight.com ([46.22.139.16]:49180 "EHLO outbound-smtp11.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423854AbcFHKKA (ORCPT ); Wed, 8 Jun 2016 06:10:00 -0400 Date: Wed, 8 Jun 2016 11:09:51 +0100 From: Mel Gorman To: Marcin Wojtas Cc: Will Deacon , Yehuda Yitschak , Robin Murphy , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Lior Amsalem , Thomas Petazzoni , Catalin Marinas , Arnd Bergmann , Grzegorz Jaszczyk , Nadav Haklai , Tomasz Nowicki , Gregory =?iso-8859-15?Q?Cl=E9ment?= Subject: Re: [BUG] Page allocation failures with newest kernels Message-ID: <20160608100950.GH2527@techsingularity.net> References: <60e8df74202e40b28a4d53dbc7fd0b22@IL-EXCH02.marvell.com> <20160531131520.GI24936@arm.com> <20160602135226.GX2527@techsingularity.net> <20160603095344.GZ2527@techsingularity.net> <20160603123655.GA2527@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 07:36:57PM +0200, Marcin Wojtas wrote: > Hi Mel, > > > > 2016-06-03 14:36 GMT+02:00 Mel Gorman : > > On Fri, Jun 03, 2016 at 01:57:06PM +0200, Marcin Wojtas wrote: > >> >> For the record: the newest kernel I was able to reproduce the dumps > >> >> was v4.6: http://pastebin.com/ekDdACn5. I've just checked v4.7-rc1, > >> >> which comprise a lot (mainly yours) changes in mm, and I'm wondering > >> >> if there may be a spot fix or rather a series of improvements. I'm > >> >> looking forward to your opinion and would be grateful for any advice. > >> >> > >> > > >> > I don't believe we want to reintroduce the reserve to cope with CMA. One > >> > option would be to widen the gap between low and min watermark by the > >> > size of the CMA region. The effect would be to wake kswapd earlier which > >> > matters considering the context of the failing allocation was > >> > GFP_ATOMIC. > >> > >> Of course my intention is not reintroducing anything that's gone > >> forever, but just to find out way to overcome current issues. Do you > >> mean increasing CMA size? > > > > No. There is a gap between the low and min watermarks. At the low point, > > kswapd is woken up and at the min point allocation requests either > > either direct reclaim or fail if they are atomic. What I'm suggesting > > is that you adjust the low watermark and add the size of the CMA area > > to it so that kswapd is woken earlier. The watermarks are calculated in > > __setup_per_zone_wmarks > > > > I printed all zones' settings, whose watermarks are configured within > __setup_per_zone_wmarks(). There are three DMA, Normal and Movable - > only first one's watermarks have non-zero values. Increasing DMA min > watermark didn't help. I also played with increasing Patch? Did you establish why GFP_ATOMIC (assuming that's the failing site) had not specified __GFP_ATOMIC at the time of the allocation failure? -- Mel Gorman SUSE Labs