From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424824AbcFHKdJ (ORCPT ); Wed, 8 Jun 2016 06:33:09 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46778 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161760AbcFHKdH (ORCPT ); Wed, 8 Jun 2016 06:33:07 -0400 Date: Wed, 8 Jun 2016 12:33:00 +0200 From: Alexandre Belloni To: Nicolas Ferre Cc: Wenyou Yang , Alan Stern , Greg Kroah-Hartman , Rob Herring , Pawel Moll , Mark Brown , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node Message-ID: <20160608103300.GE2466@piout.net> References: <1465359311-14544-1-git-send-email-wenyou.yang@atmel.com> <1465359311-14544-3-git-send-email-wenyou.yang@atmel.com> <5757EE13.1080107@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5757EE13.1080107@atmel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/06/2016 at 12:06:11 +0200, Nicolas Ferre wrote : > Le 08/06/2016 06:15, Wenyou Yang a écrit : > > Use compatible "atmel,sama5d2-ohci" to be capable of suspending > > ports while sleep to save the power consumption. > > > > Signed-off-by: Wenyou Yang > > --- > > > > Changes in v3: None > > Changes in v2: > > - Use the new compatible for ohci-node. > > > > arch/arm/boot/dts/sama5d2.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi > > index 78996bd..03d6724 100644 > > --- a/arch/arm/boot/dts/sama5d2.dtsi > > +++ b/arch/arm/boot/dts/sama5d2.dtsi > > @@ -232,7 +232,7 @@ > > }; > > > > usb1: ohci@00400000 { > > - compatible = "atmel,at91rm9200-ohci", "usb-ohci"; > > + compatible = "atmel,sama5d2-ohci", "usb-ohci"; > > We must change this to: > + compatible = "atmel,sama5d2-ohci", "atmel,at91rm9200-ohci", "usb-ohci"; > > To make it independent from the one that may reach Mainline through the USB git tree. > Well, like discussed, I'd say that a new compatible is not needed as we already know on which chip we are running depending on the SFR that we can lookup. My concern was only to avoid calling a function unnecessarily on !sama5d2 platforms. > > > reg = <0x00400000 0x100000>; > > interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>; > > clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>; > > > > Bye, > -- > Nicolas Ferre -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com