From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423273AbcFHTFk (ORCPT ); Wed, 8 Jun 2016 15:05:40 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:46553 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161583AbcFHTFi (ORCPT ); Wed, 8 Jun 2016 15:05:38 -0400 Date: Wed, 8 Jun 2016 13:05:29 -0600 From: Jason Gunthorpe To: Ed Swierk Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH v4 3/4] tpm: Allow TPM chip drivers to override reported command durations Message-ID: <20160608190529.GA26925@obsidianresearch.com> References: <1465346740-60120-1-git-send-email-eswierk@skyportsystems.com> <1465346740-60120-4-git-send-email-eswierk@skyportsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465346740-60120-4-git-send-email-eswierk@skyportsystems.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 05:45:39PM -0700, Ed Swierk wrote: > + case 0x32041114: /* Atmel 3204 */ > + chip->vendor.timeout_a = TIS_SHORT_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_b = TIS_LONG_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_c = TIS_SHORT_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_d = TIS_SHORT_TIMEOUT * HZ / 1000; Shouldn't these use msec_to_jiffies? Jason