[PATCH] Documentation/devicetree: document cavium-pip rx-delay/tx-delay properties

[PATCH] Documentation/devicetree: document cavium-pip rx-delay/tx-delay properties

[Aaro Koskinen]

Document cavium-pip rx-delay/tx-delay properties. Currently the board
specific values need to be hardcoded in the platform code, which we
want to avoid when moving to DT-only booting.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
 Documentation/devicetree/bindings/net/cavium-pip.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/cavium-pip.txt b/Documentation/devicetree/bindings/net/cavium-pip.txt
index 7dbd158..edbf411 100644
--- a/Documentation/devicetree/bindings/net/cavium-pip.txt
+++ b/Documentation/devicetree/bindings/net/cavium-pip.txt
@@ -37,6 +37,10 @@ Properties for PIP port which is a child the PIP interface:
 
 - phy-handle: Optional, see ethernet.txt file in the same directory.
 
+- rx-delay: Delay value for RGMII receive clock. Optional. Disabled if 0.
+
+- tx-delay: Delay value for RGMII transmit clock. Optional. Disabled if 0.
+
 Example:
 
 	pip@11800a0000000 {
-- 
2.7.2

Re: [PATCH] Documentation/devicetree: document cavium-pip rx-delay/tx-delay properties

[Rob Herring]

On Sun, Jun 05, 2016 at 01:24:02AM +0300, Aaro Koskinen wrote:
> Document cavium-pip rx-delay/tx-delay properties. Currently the board
> specific values need to be hardcoded in the platform code, which we
> want to avoid when moving to DT-only booting.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
>  Documentation/devicetree/bindings/net/cavium-pip.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/cavium-pip.txt b/Documentation/devicetree/bindings/net/cavium-pip.txt
> index 7dbd158..edbf411 100644
> --- a/Documentation/devicetree/bindings/net/cavium-pip.txt
> +++ b/Documentation/devicetree/bindings/net/cavium-pip.txt
> @@ -37,6 +37,10 @@ Properties for PIP port which is a child the PIP interface:
>  
>  - phy-handle: Optional, see ethernet.txt file in the same directory.
>  
> +- rx-delay: Delay value for RGMII receive clock. Optional. Disabled if 0.
> +
> +- tx-delay: Delay value for RGMII transmit clock. Optional. Disabled if 0.

What are the units? Use standard unit suffix if in ns, us, etc.

> +
>  Example:
>  
>  	pip@11800a0000000 {
> -- 
> 2.7.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Documentation/devicetree: document cavium-pip rx-delay/tx-delay properties

[Aaro Koskinen]

Hi,

On Wed, Jun 08, 2016 at 02:18:42PM -0500, Rob Herring wrote:
> On Sun, Jun 05, 2016 at 01:24:02AM +0300, Aaro Koskinen wrote:
> > Document cavium-pip rx-delay/tx-delay properties. Currently the board
> > specific values need to be hardcoded in the platform code, which we
> > want to avoid when moving to DT-only booting.
> > 
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > ---
> >  Documentation/devicetree/bindings/net/cavium-pip.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/cavium-pip.txt b/Documentation/devicetree/bindings/net/cavium-pip.txt
> > index 7dbd158..edbf411 100644
> > --- a/Documentation/devicetree/bindings/net/cavium-pip.txt
> > +++ b/Documentation/devicetree/bindings/net/cavium-pip.txt
> > @@ -37,6 +37,10 @@ Properties for PIP port which is a child the PIP interface:
> >  
> >  - phy-handle: Optional, see ethernet.txt file in the same directory.
> >  
> > +- rx-delay: Delay value for RGMII receive clock. Optional. Disabled if 0.
> > +
> > +- tx-delay: Delay value for RGMII transmit clock. Optional. Disabled if 0.
> 
> What are the units? Use standard unit suffix if in ns, us, etc.

This is a raw register value, and the mapping to actual delay varies
depending on HW, AFAIK. 

A.

Re: [PATCH] Documentation/devicetree: document cavium-pip rx-delay/tx-delay properties

[Rob Herring]

On Wed, Jun 8, 2016 at 2:51 PM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> Hi,
>
> On Wed, Jun 08, 2016 at 02:18:42PM -0500, Rob Herring wrote:
>> On Sun, Jun 05, 2016 at 01:24:02AM +0300, Aaro Koskinen wrote:
>> > Document cavium-pip rx-delay/tx-delay properties. Currently the board
>> > specific values need to be hardcoded in the platform code, which we
>> > want to avoid when moving to DT-only booting.
>> >
>> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>> > ---
>> >  Documentation/devicetree/bindings/net/cavium-pip.txt | 4 ++++
>> >  1 file changed, 4 insertions(+)
>> >
>> > diff --git a/Documentation/devicetree/bindings/net/cavium-pip.txt b/Documentation/devicetree/bindings/net/cavium-pip.txt
>> > index 7dbd158..edbf411 100644
>> > --- a/Documentation/devicetree/bindings/net/cavium-pip.txt
>> > +++ b/Documentation/devicetree/bindings/net/cavium-pip.txt
>> > @@ -37,6 +37,10 @@ Properties for PIP port which is a child the PIP interface:
>> >
>> >  - phy-handle: Optional, see ethernet.txt file in the same directory.
>> >
>> > +- rx-delay: Delay value for RGMII receive clock. Optional. Disabled if 0.
>> > +
>> > +- tx-delay: Delay value for RGMII transmit clock. Optional. Disabled if 0.
>>
>> What are the units? Use standard unit suffix if in ns, us, etc.
>
> This is a raw register value, and the mapping to actual delay varies
> depending on HW, AFAIK.

Then state that in the description.

Rob