From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbcFJGuI (ORCPT ); Fri, 10 Jun 2016 02:50:08 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54169 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbcFJGuH (ORCPT ); Fri, 10 Jun 2016 02:50:07 -0400 Date: Thu, 09 Jun 2016 23:50:05 -0700 (PDT) Message-Id: <20160609.235005.436161549558871599.davem@davemloft.net> To: bhaktipriya96@gmail.com Cc: jiri@mellanox.com, idosch@mellanox.com, tj@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue From: David Miller In-Reply-To: <20160607195946.GA11743@Karyakshetra> References: <20160607195946.GA11743@Karyakshetra> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 09 Jun 2016 23:50:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhaktipriya Shridhar Date: Wed, 8 Jun 2016 01:29:46 +0530 > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workqueue > mlxsw_wq is used for FDB notif. processing with workitems that are > involved in normal device operation && because it's a network device > which can be depended upon during memory reclaim. > > Workitems &trans->timeout_dw and &mlxsw_sp->fdb_notify.dw, > map to mlxsw_sp_fdb_notify_work (processes FDB notifications from the > underlying device and resolves the netdev to which the entry points to > and notifies the bridge using the switchdev notifier) and > mlxsw_emad_trans_timeout_work (provides async EMAD register access) > respectively. They require forward progress under memory pressure and > hence, WQ_MEM_RECLAIM has been set. > > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar Applied.