linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 1/8] net: dsa: mv88e6xxx: fix style issues
Date: Thu, 9 Jun 2016 04:22:48 +0200	[thread overview]
Message-ID: <20160609022248.GG2227@lunn.ch> (raw)
In-Reply-To: <20160609004456.5441-2-vivien.didelot@savoirfairelinux.com>

On Wed, Jun 08, 2016 at 08:44:49PM -0400, Vivien Didelot wrote:
> This patch fixes 5 style problems reported by checkpatch:
> 
>     WARNING: suspect code indent for conditional statements (8, 24)
>     #492: FILE: drivers/net/dsa/mv88e6xxx.c:492:
>     +	if (phydev->link)
>     +			reg |= PORT_PCS_CTRL_LINK_UP;
> 
>     CHECK: Logical continuations should be on the previous line
>     #1318: FILE: drivers/net/dsa/mv88e6xxx.c:1318:
>     +		     oldstate == PORT_CONTROL_STATE_FORWARDING)
>     +		    && (state == PORT_CONTROL_STATE_DISABLED ||
> 
>     CHECK: multiple assignments should be avoided
>     #1662: FILE: drivers/net/dsa/mv88e6xxx.c:1662:
>     +		vlan->vid_begin = vlan->vid_end = next.vid;
> 
>     WARNING: line over 80 characters
>     #2097: FILE: drivers/net/dsa/mv88e6xxx.c:2097:
>     +				       const struct switchdev_obj_port_vlan *vlan,
> 
>     WARNING: suspect code indent for conditional statements (16, 32)
>     #2734: FILE: drivers/net/dsa/mv88e6xxx.c:2734:
>     +		if (mv88e6xxx_6352_family(ps) || mv88e6xxx_6351_family(ps) ||
>     [...]
>     +				reg |= PORT_CONTROL_EGRESS_ADD_TAG;
> 
>     total: 0 errors, 3 warnings, 2 checks, 3805 lines checked
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2016-06-09  2:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09  0:44 [PATCH net-next 0/8] net: dsa: mv88e6xxx: misc probe improvements Vivien Didelot
2016-06-09  0:44 ` [PATCH net-next 1/8] net: dsa: mv88e6xxx: fix style issues Vivien Didelot
2016-06-09  2:22   ` Andrew Lunn [this message]
2016-06-09  0:44 ` [PATCH net-next 2/8] net: dsa: mv88e6xxx: remove redundant assignments Vivien Didelot
2016-06-09  2:30   ` Andrew Lunn
2016-06-09  0:44 ` [PATCH net-next 3/8] net: dsa: mv88e6xxx: use already declared variables Vivien Didelot
2016-06-09  2:31   ` Andrew Lunn
2016-06-09  0:44 ` [PATCH net-next 4/8] net: dsa: mv88e6xxx: do not increment bus refcount Vivien Didelot
2016-06-09  2:36   ` Andrew Lunn
2016-06-10 19:59     ` Vivien Didelot
2016-06-10 20:06       ` Andrew Lunn
2016-06-09  0:44 ` [PATCH net-next 5/8] net: dsa: mv88e6xxx: add switch register helpers Vivien Didelot
2016-06-09  2:39   ` Andrew Lunn
2016-06-09 12:53     ` Vivien Didelot
2016-06-09  0:44 ` [PATCH net-next 6/8] net: dsa: mv88e6xxx: add chip detection helper Vivien Didelot
2016-06-09  0:44 ` [PATCH net-next 7/8] net: dsa: mv88e6xxx: explicit compatible devices Vivien Didelot
2016-06-09  2:14   ` Andrew Lunn
2016-06-10 20:26     ` Vivien Didelot
2016-06-09  0:44 ` [PATCH net-next 8/8] net: dsa: mv88e6xxx: fail on mismatching probe Vivien Didelot
2016-06-09  2:21   ` Andrew Lunn
2016-06-10 20:32     ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160609022248.GG2227@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).