From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161981AbcFIHKj (ORCPT ); Thu, 9 Jun 2016 03:10:39 -0400 Received: from mail.kernel.org ([198.145.29.136]:51921 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161269AbcFIHKh (ORCPT ); Thu, 9 Jun 2016 03:10:37 -0400 Date: Thu, 9 Jun 2016 10:10:14 +0300 From: Leon Romanovsky To: Lijun Ou Cc: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v9 09/22] IB/hns: Add hca support Message-ID: <20160609071014.GR3663@leon.nu> Reply-To: leon@kernel.org References: <1464795484-77395-1-git-send-email-oulijun@huawei.com> <1464795484-77395-10-git-send-email-oulijun@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4NNqsQ/a67jpuySk" Content-Disposition: inline In-Reply-To: <1464795484-77395-10-git-send-email-oulijun@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4NNqsQ/a67jpuySk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 01, 2016 at 11:37:51PM +0800, Lijun Ou wrote: > This patch mainly setup hca for RoCE. It will do a series of > initial works, as follows: > 1. init uar table, allocate uar resource > 2. init pd table > 3. init cq table > 4. init mr table > 5. init qp table >=20 > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao > Signed-off-by: Lijun Ou > --- <...> > + > + ret =3D hns_roce_bitmap_init(&cq_table->bitmap, hr_dev->caps.num_cqs, > + hr_dev->caps.num_cqs - 1, > + hr_dev->caps.reserved_cqs, 0); > + if (ret) > + return ret; > + > + return 0; You can return directly ret, instead last 4 lines. > +} > + --4NNqsQ/a67jpuySk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXWRZWAAoJEORje4g2clinNc4P/3Y4W91zCrYR7O0KTWUezW3B NVlwX0Ow0qpFdgqANW+Rx3YqrbuF12oFwNkBEajP0eGlpkdZN2oUqHPu0eA7mV80 TeDQWeGjtrJHjB9fYSBGn8cTG8d+cO3jHzW1HwYbdtEy9+qesnibKmemkCHuJdSA ZNufLVvLSTPwNaq3DBg4RzFnMPFF6f8GoJxX/dn2P0DQScSN1qZJuyZ1/EVkRIRV +Eh1fywiHHCU6+FplbbpHHE/x+Hx+HFGMRPi/78ilu2vttdUC6Wjbbgr00dfHMi+ aXferVP7upjI8+iRDVb8pBErEqJAUCMFvwregBX4AX5gQrcOjU+/sDBMwMiD5b+U F68yI8R/NfBA8P6lfiZfJ7J9Wy3I1g6/1Uikl0nseQRPaqnYeAFfmf6pByXMdktL W+55mV56TXn3nKQrD72rqajfw0k+X+66BboWlWFFTcGOatxoQPBf+7Cm4ztqDA+i IQGiTTt6BD6YMeJgmMi4PhqZtrSmX1iN7i3u7ENkWpv3DwiqZDy1+AboE8hdfv8G /b73s46eDkTECZf6iYNdZm1/KwSNnpQSpciFBJO2fJU4LuskgEyTmXmhlVvLIlpv xgvEML2jSnuSAOE2OhHB+UYpT+T/ggQsk2EmteJmyETf8L0M7CCvnlnUX3jhKlqG zd8xfZcN4uGu6ajV6/wO =ov7W -----END PGP SIGNATURE----- --4NNqsQ/a67jpuySk--