From: Brian Starkey <brian.starkey@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: "Sumit Semwal" <sumit.semwal@linaro.org>,
"John Stultz" <john.stultz@linaro.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
"Laura Abbott" <labbott@fedoraproject.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
linaro-mm-sig@lists.linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
"Eun Taik Lee" <eun.taik.lee@samsung.com>,
"Liviu Dudau" <Liviu.Dudau@arm.com>,
"Jon Medhurst" <tixy@linaro.org>,
"Mitchel Humpherys" <mitchelh@codeaurora.org>,
"Jeremy Gebben" <jgebben@codeaurora.org>,
"Bryan Huntsman" <bryanh@codeaurora.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Android Kernel Team" <kernel-team@android.com>
Subject: Re: [RFC][PATCH 6/6] staging: android: ion: Introduce new ioctls for dynamic heaps
Date: Thu, 9 Jun 2016 09:25:02 +0100 [thread overview]
Message-ID: <20160609082502.GA31014@e106950-lin.cambridge.arm.com> (raw)
In-Reply-To: <9356ed78-76eb-ceac-30fa-b4496e6e3ae0@redhat.com>
Hi Laura,
On Wed, Jun 08, 2016 at 12:14:12PM -0700, Laura Abbott wrote:
>
>For now I'm just going to focus on comments not about the heap ID mapping
>because I'm leaning towards dropping the heap ID mapping.
>
Fair enough. Like you said, giving userspace enough information to just
figure out the right heap IDs is already a big improvement.
>
>I'm not that familiar with the DRM ioctls but this sounds like a
>good suggestion. One less ioctl to worry about.
>
Sorry, I probably should have pointed to an example:
http://lxr.free-electrons.com/source/drivers/gpu/drm/drm_crtc.c#L2325
>>>+ */
>>>+struct ion_heap_query {
>>>+ __u32 cnt; /* Total number of heaps to be copied */
>>>+ __u64 heaps; /* buffer to be populated */
>>
>>I guess this field needs explicit alignment to 64 bits
>>
>
>Yes, I was going by the suggestion in botching-up-ioctls.txt
>
>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/ioctl/botching-up-ioctls.txt#n42
>
The type is fine, but you should add a 32-bit padding field before
heaps:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/ioctl/botching-up-ioctls.txt#n32
Cheers,
-Brian
next prev parent reply other threads:[~2016-06-09 8:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 18:23 [RFC][PATCH 0/6] ion: improved ABI Laura Abbott
2016-06-06 18:23 ` [RFC][PATCH 1/6] staging: android: ion: return error value for ion_device_add_heap Laura Abbott
2016-06-08 13:02 ` Liviu Dudau
2016-06-06 18:23 ` [RFC][PATCH 2/6] staging: android: ion: Switch to using an idr to manage heaps Laura Abbott
2016-06-08 13:13 ` Liviu Dudau
2016-06-06 18:23 ` [RFC][PATCH 3/6] staging: android: ion: Drop heap type masks Laura Abbott
2016-06-06 18:23 ` [RFC][PATCH 4/6] staging: android: ion: Pull out ion ioctls to a separate file Laura Abbott
2016-06-08 13:20 ` Liviu Dudau
2016-06-06 18:23 ` [RFC][PATCH 5/6] staging: android: ion: Add an ioctl for ABI checking Laura Abbott
2016-06-06 18:23 ` [RFC][PATCH 6/6] staging: android: ion: Introduce new ioctls for dynamic heaps Laura Abbott
2016-06-08 13:50 ` Liviu Dudau
2016-06-08 17:35 ` Laura Abbott
2016-06-08 15:34 ` Brian Starkey
2016-06-08 19:14 ` Laura Abbott
2016-06-09 8:25 ` Brian Starkey [this message]
2016-06-07 6:59 ` [Linaro-mm-sig] [RFC][PATCH 0/6] ion: improved ABI Chen Feng
2016-06-08 17:29 ` Laura Abbott
2016-06-08 15:15 ` Brian Starkey
2016-06-08 18:58 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609082502.GA31014@e106950-lin.cambridge.arm.com \
--to=brian.starkey@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=arve@android.com \
--cc=bryanh@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=eun.taik.lee@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgebben@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=labbott@fedoraproject.org \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitchelh@codeaurora.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).