From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752239AbcFIKpU (ORCPT ); Thu, 9 Jun 2016 06:45:20 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:32768 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbcFIKpR (ORCPT ); Thu, 9 Jun 2016 06:45:17 -0400 Date: Thu, 9 Jun 2016 16:08:17 +0530 From: maitysanchayan@gmail.com To: Rob Herring Cc: arnd@arndb.de, Shawn Guo , Stefan Agner , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform Message-ID: <20160609103817.GA14965@Sanchayan-Arch.localdomain> References: <20160527063301.GB1554@Sanchayan-Arch.localdomain> <9495361.v6aft1QR0M@wuerfel> <20160527100817.GA8294@Sanchayan-Arch.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160527100817.GA8294@Sanchayan-Arch.localdomain> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, On 16-05-27 15:38:17, maitysanchayan@gmail.com wrote: > On 16-05-27 10:31:55, Arnd Bergmann wrote: > > On Friday, May 27, 2016 12:03:01 PM CEST maitysanchayan@gmail.com wrote: > > > > > > So if I understand correctly, the binding at the SoC level is fine. > > > Keeping that but removing the additional made-up properties, viz. below > > > > > > rom-revision: phandle to the on-chip ROM node > > > mscm: phandle to the MSCM CPU configuration node > > > nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1 > > > nvmem-cell-names: should contain string names "cfg0" and "cfg1" > > > > > > would be fine? > > > > > > We would have something similar to here > > > http://www.spinics.net/lists/devicetree/msg80655.html > > > > > > but now with the DT binding under SoC bus. > > > > > > > > > You look up the OTP device as a syscon here, which seems odd since there > > is already an nvmem driver for it. Shouldn't you use the nvmem API for > > that? > > > > Arnd > > I need the following > > nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1 > nvmem-cell-names: should contain string names "cfg0" and "cfg1" > > to be able to use the NVMEM consumer API. > > If I can put them at SoC node level then I certainly can use the NVMEM API. > Would the following be acceptable at the SoC node level > nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1 > nvmem-cell-names: should contain string names "cfg0" and "cfg1" Regards, Sanchayan.