From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751687AbcFIMgE (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Jun 2016 08:36:04 -0400
Received: from merlin.infradead.org ([205.233.59.134]:59299 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750796AbcFIMgC (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Jun 2016 08:36:02 -0400
Date: Thu, 9 Jun 2016 14:35:57 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Minfei Huang <mnghuan@gmail.com>, bp@suse.de, luto@kernel.org,
        hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3 V2] pvclock: Get rid of __pvclock_read_cycles in
 function pvclock_read_flags
Message-ID: <20160609123557.GP30909@twins.programming.kicks-ass.net>
References: <1464329832-4638-3-git-send-email-mnghuan@gmail.com>
 <1464438463-8485-1-git-send-email-mnghuan@gmail.com>
 <20160609121603.GB30935@twins.programming.kicks-ass.net>
 <685113ad-c337-8207-89f6-1a0b475c44fb@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <685113ad-c337-8207-89f6-1a0b475c44fb@redhat.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 09, 2016 at 02:26:59PM +0200, Paolo Bonzini wrote:
> 
> 
> On 09/06/2016 14:16, Peter Zijlstra wrote:
> > On Sat, May 28, 2016 at 08:27:43PM +0800, Minfei Huang wrote:
> >> +++ b/arch/x86/kernel/pvclock.c
> >> @@ -61,11 +61,14 @@ void pvclock_resume(void)
> >>  u8 pvclock_read_flags(struct pvclock_vcpu_time_info *src)
> >>  {
> >>  	unsigned version;
> >> -	cycle_t ret;
> >>  	u8 flags;
> >>  
> >>  	do {
> >> -		version = __pvclock_read_cycles(src, &ret, &flags);
> >> +		version = src->version;
> >> +		/* Make the latest version visible */
> >> +		smp_rmb();
> >> +
> >> +		flags = src->flags;
> > 
> > Using a seqcount to load a single byte is insane ;-)
> 
> Only if you know that the writer will not write that byte twice within a
> critical section...
> 
> Which I guess we do know in this case because the write side is just a
> memcpy, but it's still a bit safer when it's not specified by the
> pvclock API.  It's not a fast path anyway, it runs literally twice at
> startup.

Fair enough; just thought it was really silly code.