From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932178AbcFIOO5 (ORCPT ); Thu, 9 Jun 2016 10:14:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59559 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbcFIOO4 (ORCPT ); Thu, 9 Jun 2016 10:14:56 -0400 Date: Thu, 9 Jun 2016 16:14:51 +0200 From: Benjamin Tissoires To: Corey Minyard Cc: Jean Delvare , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Corey Minyard Subject: Re: [v2,09/10] i2c-i801: Null isr data buffer when done with it Message-ID: <20160609141451.GK24234@mail.corp.redhat.com> References: <1464570544-975-10-git-send-email-minyard@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1464570544-975-10-git-send-email-minyard@acm.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 09 Jun 2016 14:14:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 29 2016 or thereabouts, Corey Minyard wrote: > From: Corey Minyard > > Don't leave a pointer to some external buffer lying around. > > Signed-off-by: Corey Minyard > --- Looks good to me. Reviewed-by: Benjamin Tissoires > drivers/i2c/busses/i2c-i801.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index 70da60a..bb15356 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -598,6 +598,7 @@ static int i801_block_transaction_byte_by_byte(struct i801_priv *priv, > dev_warn(&priv->pci_dev->dev, > "Timeout waiting for interrupt!\n"); > } > + priv->data = NULL; > priv->status = 0; > return status; > }