From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932204AbcFIOXB (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Jun 2016 10:23:01 -0400
Received: from mail.kernel.org ([198.145.29.136]:55650 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932069AbcFIOW7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Jun 2016 10:22:59 -0400
Date: Thu, 9 Jun 2016 11:22:55 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: Re: [PATCH perf/core v10 09/23] perf probe: Show all cached probes
Message-ID: <20160609142255.GP11589@kernel.org>
References: <20160608092854.3116.29007.stgit@devbox>
 <20160608093030.3116.74450.stgit@devbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160608093030.3116.74450.stgit@devbox>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Jun 08, 2016 at 06:30:30PM +0900, Masami Hiramatsu escreveu:
> +char *build_id_cache__origname(const char *sbuild_id)
> +{
> +	char *linkname;
> +	char buf[PATH_MAX];
> +	char *ret = NULL, *p;
> +	size_t offs = 5;	/* == strlen("../..") */
> +
> +	linkname = build_id_cache__linkname(sbuild_id, NULL, 0);
> +	if (!linkname)
> +		return NULL;
> +
> +	if (readlink(linkname, buf, PATH_MAX) < 0)
> +		goto out;
> +	/* The link should be "../..<origpath>/<sbuild_id>" */
> +	p = strrchr(buf, '/');	/* Cut off the "/<sbuild_id>" */
> +	if (p && (p > buf + offs)) {
> +		*p = '\0';
> +		if (buf[offs + 1] == '[')
> +			offs++;	/*
> +				 * This is a DSO name, like [kernel.kallsyms].
> +				 * Skip the first '/', since this is not the
> +				 * cache of a regular file.
> +				 */
> +		ret = strdup(buf + offs);	/* Skip "../..[/]" */

strdup can fail.

> +	}
> +out:
> +	free(linkname);
> +	return ret;
> +}
> +
>  static const char *build_id_cache__basename(bool is_kallsyms, bool is_vdso)
>  {
>  	return is_kallsyms ? "kallsyms" : (is_vdso ? "vdso" : "elf");
> @@ -390,6 +419,59 @@ void disable_buildid_cache(void)
>  	no_buildid_cache = true;
>  }
>  
> +int build_id_cache__list_all(struct strlist **result)
> +{
> +	struct strlist *toplist, *list, *bidlist;
> +	struct str_node *nd, *nd2;
> +	char *topdir, *linkdir;
> +	char sbuild_id[SBUILD_ID_SIZE];
> +	int ret = 0;
> +
> +	/* Open the top-level directory */
> +	if (asprintf(&topdir, "%s/.build-id/", buildid_dir) < 0)
> +		return -errno;

Wouldn't be better to just return -1 and leave the caller to look at
errno? I know that there is code that does that, but better stick to the
errno convention?

> +	toplist = lsdir(topdir, lsdir_no_dot_filter);
> +	if (!toplist) {
> +		pr_debug("Failed to opendir %s\n", topdir);
> +		ret = -errno;

ditto

> +		goto out;
> +	}
> +	bidlist = strlist__new(NULL, NULL);
> +	strlist__for_each(nd, toplist) {
> +		if (asprintf(&linkdir, "%s/%s", topdir, nd->s) < 0) {
> +			ret = -errno;
> +			goto out;
> +		}
> +		/* Open the lower-level directory */
> +		list = lsdir(linkdir, lsdir_no_dot_filter);
> +		if (!list) {
> +			pr_debug("Failed to open %s: %d\n", linkdir, -errno);
> +			goto next;
> +		}
> +		strlist__for_each(nd2, list) {
> +			ret = snprintf(sbuild_id, SBUILD_ID_SIZE, "%s%s",
> +					nd->s, nd2->s);
> +			if (ret != SBUILD_ID_SIZE - 1) {
> +				pr_debug("%s/%s is not buildid cache\n",
> +					nd->s, nd2->s);
> +				continue;
> +			}
> +			strlist__add(bidlist, sbuild_id);

strlist__add() can fail, please check its result.

> +		}
> +		strlist__delete(list);
> +next:
> +		free(linkdir);
> +	}
> +
> +	*result = bidlist;
> +out:
> +	if (toplist)
> +		strlist__delete(toplist);

No need for checking toplist.

> +	free(topdir);
> +
> +	return ret;
> +}

<SNIP>

- Arnaldo