From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbcFIWQP (ORCPT ); Thu, 9 Jun 2016 18:16:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58183 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932281AbcFIWQE (ORCPT ); Thu, 9 Jun 2016 18:16:04 -0400 Date: Thu, 9 Jun 2016 15:16:03 -0700 From: Andrew Morton To: Sudip Mukherjee Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] m32r: add __ucmpdi2 to fix build failure Message-Id: <20160609151603.79da214c8133130e92ff689a@linux-foundation.org> In-Reply-To: <1465509213-4280-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1465509213-4280-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Jun 2016 22:53:33 +0100 Sudip Mukherjee wrote: > We are having build failure with m32r and the error message being: > ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined! > ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined! > ERROR: "__ucmpdi2" [drivers/scsi/sd_mod.ko] undefined! > ERROR: "__ucmpdi2" [drivers/media/i2c/adv7842.ko] undefined! > ERROR: "__ucmpdi2" [drivers/md/bcache/bcache.ko] undefined! > ERROR: "__ucmpdi2" [drivers/iio/imu/inv_mpu6050/inv-mpu6050.ko] undefined! > > __ucmpdi2 is introduced to m32r architecture taking example from other > architectures like h8300, microblaze, mips. > > --- a/arch/m32r/kernel/m32r_ksyms.c > +++ b/arch/m32r/kernel/m32r_ksyms.c > @@ -41,6 +41,9 @@ EXPORT_SYMBOL(cpu_data); > EXPORT_SYMBOL(smp_flush_tlb_page); > #endif > > +extern int __ucmpdi2(unsigned long long a, unsigned long long b); > +EXPORT_SYMBOL(__ucmpdi2); > + This would be neater. Does it work? From: Andrew Morton Subject: m32r-add-__ucmpdi2-to-fix-build-failure-fix avoid extern declaration in .c file Cc: Sudip Mukherjee Cc: Sudip Mukherjee Signed-off-by: Andrew Morton --- a/arch/m32r/kernel/m32r_ksyms.c~m32r-add-__ucmpdi2-to-fix-build-failure-fix +++ a/arch/m32r/kernel/m32r_ksyms.c @@ -41,7 +41,6 @@ EXPORT_SYMBOL(cpu_data); EXPORT_SYMBOL(smp_flush_tlb_page); #endif -extern int __ucmpdi2(unsigned long long a, unsigned long long b); EXPORT_SYMBOL(__ucmpdi2); /* compiler generated symbol */ --- a/arch/m32r/lib/libgcc.h~m32r-add-__ucmpdi2-to-fix-build-failure-fix +++ a/arch/m32r/lib/libgcc.h @@ -22,3 +22,4 @@ typedef union { #endif /* __ASM_LIBGCC_H */ +extern int __ucmpdi2(unsigned long long a, unsigned long long b);