From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751980AbcFKBQt (ORCPT ); Fri, 10 Jun 2016 21:16:49 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33887 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbcFKBQr (ORCPT ); Fri, 10 Jun 2016 21:16:47 -0400 Date: Fri, 10 Jun 2016 18:16:46 -0700 (PDT) Message-Id: <20160610.181646.1722421370385177808.davem@davemloft.net> To: vpalatin@chromium.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, dianders@chromium.org, peppe.cavallaro@st.com, heiko@sntech.de, zhengsq@rock-chips.com Subject: Re: net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288 From: David Miller In-Reply-To: <1465606839-7722-1-git-send-email-vpalatin@chromium.org> References: <1465606839-7722-1-git-send-email-vpalatin@chromium.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 10 Jun 2016 18:16:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vincent Palatin Date: Fri, 10 Jun 2016 18:00:36 -0700 > In order to support Wake-On-Lan when using the RK3288 integrated MAC > (with an external RGMII PHY), we need to avoid shutting down the regulator > of the external PHY when the MAC is suspended as it's currently done in the MAC > platform code. > As a first step, create independant callbacks for suspend/resume rather than > re-using exit/init callbacks. So the dwmac platform driver can behave differently > on suspend where it might skip shutting the PHY and at module unloading. > Then update the dwmac-rk driver to switch off the PHY regulator only if we are > not planning to wake up from the LAN. > Finally add the PMT interrupt to the MAC device tree configuration, so we can > wake up the core from it when the PHY has received the magic packet. > Ignore my previous email, but in the future please tag these postings properly with "[PATCH 0/N] " at the beginning of the subject line. Thanks.