From: Sebastian Reichel <sre@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] power_supply: bq27xxx_battery: Group register mappings into one table
Date: Fri, 10 Jun 2016 03:29:34 +0200 [thread overview]
Message-ID: <20160610012934.GA5848@earth> (raw)
In-Reply-To: <20160531184500.10871-3-afd@ti.com>
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
Hi,
On Tue, May 31, 2016 at 01:45:00PM -0500, Andrew F. Davis wrote:
> Currently for each device with a unique register map we have a named
> array that we then merge into a multidimensional array. Skip this
> middle step and apply the register arrays directly to the multi-array.
I applied the first two patches, but the third (this one) does not
compile for me:
CC [M] drivers/power/bq27xxx_battery.o
drivers/power/bq27xxx_battery.c:108:2: warning: braces around scalar initializer
[BQ27000] = {
^
drivers/power/bq27xxx_battery.c:108:2: note: (near initialization for ‘bq27xxx_regs[1]’)
drivers/power/bq27xxx_battery.c:109:4: error: array index in non-array initializer
[BQ27XXX_REG_CTRL] = 0x00,
^
drivers/power/bq27xxx_battery.c:109:4: note: (near initialization for ‘bq27xxx_regs[1]’)
drivers/power/bq27xxx_battery.c:110:4: error: array index in non-array initializer
[BQ27XXX_REG_TEMP] = 0x06,
^
...
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-10 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 18:44 [PATCH 1/3] power_supply: bq27xxx_battery: Fix copy/paste error in header comment Andrew F. Davis
2016-05-31 18:44 ` [PATCH 2/3] power_supply: bq27xxx_battery: Index register numbers by enum Andrew F. Davis
2016-05-31 18:45 ` [PATCH 3/3] power_supply: bq27xxx_battery: Group register mappings into one table Andrew F. Davis
2016-06-10 1:29 ` Sebastian Reichel [this message]
2016-06-17 22:00 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610012934.GA5848@earth \
--to=sre@kernel.org \
--cc=afd@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).