From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbcFJHgr (ORCPT ); Fri, 10 Jun 2016 03:36:47 -0400 Received: from down.free-electrons.com ([37.187.137.238]:48472 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750921AbcFJHgq (ORCPT ); Fri, 10 Jun 2016 03:36:46 -0400 Date: Fri, 10 Jun 2016 09:36:43 +0200 From: Maxime Ripard To: Mark Brown Cc: Rob Herring , Chen-Yu Tsai , Liam Girdwood , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Andrea Venturi , Code Kipper , gianfranco@moddevices.com Subject: Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Message-ID: <20160610073643.GK5242@lukather> References: <20160601175430.11625-1-maxime.ripard@free-electrons.com> <20160601175430.11625-3-maxime.ripard@free-electrons.com> <20160602102651.GF2282@sirena.org.uk> <20160609210515.GI5242@lukather> <20160610003755.GC7510@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/jkxxxtAhYIHVDuh" Content-Disposition: inline In-Reply-To: <20160610003755.GC7510@sirena.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/jkxxxtAhYIHVDuh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mark, On Fri, Jun 10, 2016 at 01:37:55AM +0100, Mark Brown wrote: > > > > +static int sun4i_i2s_dai_probe(struct snd_soc_dai *dai) > > > > +{ > > > > + struct sun4i_i2s *i2s =3D snd_soc_dai_get_drvdata(dai); >=20 > > > > + /* Enable the whole hardware block */ > > > > + regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG, > > > > + SUN4I_I2S_CTRL_GL_EN); >=20 > > > Runtime PM? It also seems like this is something that ought to be > > > covered in the suspend and resume callbacks. >=20 > > runtime_pm is supported, and uses the regmap cache to keep those > > changes. >=20 > No, my point is that I'd expect to see the block powered off on suspend. It is. The bus clock is disabled, which also puts the IP in reset. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --/jkxxxtAhYIHVDuh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXWm4LAAoJEBx+YmzsjxAgvIwP/A8O8UV4qXeBuFLrSdmJsFYN sqoFcjUVTPpR1Cm2wCa6/pHitavmK3t+OOSuRMaKzDhpZLcf8NqJWU6Mx7ueyzNc ev2FOkYJDUGWt2hqv7nsVxQLXVh2p+2h+YJ4iGj7JN90/vZVxP4qG8dp/dkTOsSN U5sYhTJYH4QwuIrdXoEIffQDS0Koex6SnvdBVyKrJjfydLLTZ8u/+ufKUozDB2hH 9UvxpocTeyCqpoc4t6XX3+tifzqhHnAwu/apvBCKssKZELN/jI6XS0qOBh/ivQqj 9QYlfmZbDZaw6LQTJFVYS/oYiUPrqWsLwE763Zn1Imr2/zyksdrltt7bX2ryTuDy 3LvBChUYdP/5kA4T/hPbbKncHzGO199n4iZRZ52dyOAhKLaD6Kn1bgVW8awyMvIc Wra/eH4Xo+EfZATZdcZ99wPYx0SLaLJOSOozgvcL94lBr4xqFzNrCBJnhGcbM7pG tdrBfM0Th6YfynXi0SRvyAUNTToXsb/CvFmxeL0SEHSu2MD6Dgu6YNb75Nei8dM6 tHrB7EJi3sPMYC+nDyRlJQ8YCeeEcEOHGxc303hjXhASFmLhapzxyhxqEWG1sWoB UZV/XkePIaVYLOt4fANgQNJr2qMC69UcANhv5rxuPHplarG0boV/AFyJKOoUiUxD L8wPhaMJpse7daqKp4vb =3P9E -----END PGP SIGNATURE----- --/jkxxxtAhYIHVDuh--