From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933180AbcFJMvH (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 08:51:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59620 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932180AbcFJMvD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 08:51:03 -0400
Date: Fri, 10 Jun 2016 14:50:56 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        Borislav Petkov <bp@alien8.de>, Andi Kleen <andi@firstfloor.org>,
        stable@vger.kernel.org, Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: Re: [PATCH v2] x86/traps: Don't force in_interrupt() to return true
 in IST handlers
Message-ID: <20160610125056.GA8005@redhat.com>
References: <cdc215f94d118d691d73df35275022331156fb45.1464130360.git.luto@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cdc215f94d118d691d73df35275022331156fb45.1464130360.git.luto@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 10 Jun 2016 12:51:03 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/24, Andy Lutomirski wrote:
>
>  void ist_enter(struct pt_regs *regs)
>  {
>  	if (user_mode(regs)) {
> @@ -109,13 +115,7 @@ void ist_enter(struct pt_regs *regs)
>  		rcu_nmi_enter();
>  	}
>  
> -	/*
> -	 * We are atomic because we're on the IST stack; or we're on
> -	 * x86_32, in which case we still shouldn't schedule; or we're
> -	 * on x86_64 and entered from user mode, in which case we're
> -	 * still atomic unless ist_begin_non_atomic is called.
> -	 */
> -	preempt_count_add(HARDIRQ_OFFSET);
> +	preempt_disable();

off-topic question,

perhaps it makes sense to remove another preempt_disable/preempt_enable_no_resched
in do_int3() and do_debug() ?

They were added by d99e1bd175f4291ddb6e62b22bb5bdbe3976389a ("x86/entry/traps: Refactor
preemption and interrupt flag handling") and afaics for no reason.

Oleg.