From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751254AbcFKI2S (ORCPT ); Sat, 11 Jun 2016 04:28:18 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:60490 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802AbcFKI2O convert rfc822-to-8bit (ORCPT ); Sat, 11 Jun 2016 04:28:14 -0400 Date: Sat, 11 Jun 2016 10:27:54 +0200 From: Jean-Francois Moine To: Maxime Ripard Cc: Mike Turquette , Stephen Boyd , Chen-Yu Tsai , linux-clk@vger.kernel.org, Hans de Goede , Andre Przywara , Rob Herring , Vishnu Patekar , linux-arm-kernel@lists.infradead.org, Boris Brezillon , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 08/15] clk: sunxi-ng: Add divider Message-Id: <20160611102754.394c28863c2f50d5d29b94a1@free.fr> In-Reply-To: <20160607204154.31967-9-maxime.ripard@free-electrons.com> References: <20160607204154.31967-1-maxime.ripard@free-electrons.com> <20160607204154.31967-9-maxime.ripard@free-electrons.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; armv7l-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Jun 2016 22:41:47 +0200 Maxime Ripard wrote: > Add support for the various dividers (linear, table or pow-of-two based) > found in the CCU. > > Signed-off-by: Maxime Ripard > --- > drivers/clk/sunxi-ng/Makefile | 1 + > drivers/clk/sunxi-ng/ccu_div.c | 136 +++++++++++++++++++++++++++++++++++++++++ > drivers/clk/sunxi-ng/ccu_div.h | 135 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 272 insertions(+) > create mode 100644 drivers/clk/sunxi-ng/ccu_div.c > create mode 100644 drivers/clk/sunxi-ng/ccu_div.h > > diff --git a/drivers/clk/sunxi-ng/Makefile b/drivers/clk/sunxi-ng/Makefile > index c47cbd309d59..67a2559fe283 100644 > --- a/drivers/clk/sunxi-ng/Makefile > +++ b/drivers/clk/sunxi-ng/Makefile > @@ -3,6 +3,7 @@ obj-y += ccu_reset.o > > obj-y += ccu_frac.o > > +obj-y += ccu_div.o > obj-y += ccu_fixed_factor.o > obj-y += ccu_gate.o > obj-y += ccu_mux.o > diff --git a/drivers/clk/sunxi-ng/ccu_div.c b/drivers/clk/sunxi-ng/ccu_div.c > new file mode 100644 > index 000000000000..8659b4cb6c20 > --- /dev/null > +++ b/drivers/clk/sunxi-ng/ccu_div.c > @@ -0,0 +1,136 @@ [snip] > diff --git a/drivers/clk/sunxi-ng/ccu_div.h b/drivers/clk/sunxi-ng/ccu_div.h > new file mode 100644 > index 000000000000..5edbdc1a98c8 > --- /dev/null > +++ b/drivers/clk/sunxi-ng/ccu_div.h > @@ -0,0 +1,135 @@ [snip] > +#define SUNXI_CCU_M_WITH_GATE(_struct, _name, _parent, _reg, \ > + _mshift, _mwidth, _gate, \ > + _flags) \ > + struct ccu_div _struct = { \ > + .enable = _gate, \ > + .div = _SUNXI_CCU_DIV(_mshift, _mwidth), \ > + .common = { \ > + .reg = _reg, \ > + .features = CCU_FEATURE_GATE, \ > + .hw.init = SUNXI_HW_INIT(_name, \ > + _parent, \ > + &ccu_div_ops, \ > + _flags), \ > + }, \ > + } > + > +#define SUNXI_CCU_M(_struct, _name, _parent, _reg, _mshift, _mwidth, \ > + _flags) \ > + SUNXI_CCU_M_WITH_GATE(_struct, _name, _parent, _reg, \ > + _mshift, _mwidth, 0, _flags) [snip] This shows that the flag CCU_FEATURE_GATE is perfectly useless... -- Ken ar c'hentań | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/