From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932553AbcFLMC2 (ORCPT ); Sun, 12 Jun 2016 08:02:28 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33324 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752702AbcFLMC0 (ORCPT ); Sun, 12 Jun 2016 08:02:26 -0400 Date: Sun, 12 Jun 2016 19:56:22 +0800 From: Dong Aisheng To: Lothar Wa??mann Cc: Dong Aisheng , anson.huang@nxp.com, mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, shawnguo@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3 Message-ID: <20160612115622.GD32690@shlinux2> References: <1465396420-27064-1-git-send-email-aisheng.dong@nxp.com> <1465396420-27064-5-git-send-email-aisheng.dong@nxp.com> <20160609094328.136b7bf8@ipc1.ka-ro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160609094328.136b7bf8@ipc1.ka-ro> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2016 at 09:43:28AM +0200, Lothar Wa??mann wrote: > Hi, > > On Wed, 8 Jun 2016 22:33:34 +0800 Dong Aisheng wrote: > > There's a powerdown bit already, so let's change the name of > > powerup_set bit to power_invert to reflects the power polarity > > to make it less confusing. > > > > Signed-off-by: Dong Aisheng > > --- > > drivers/clk/imx/clk-pllv3.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > > index eea2b1b3791e..3fdfb6d2cc71 100644 > > --- a/drivers/clk/imx/clk-pllv3.c > > +++ b/drivers/clk/imx/clk-pllv3.c > > @@ -29,8 +29,8 @@ > > * struct clk_pllv3 - IMX PLL clock version 3 > > * @clk_hw: clock source > > * @base: base address of PLL registers > > - * @powerup_set: set POWER bit to power up the PLL > > - * @powerdown: pll powerdown offset bit > > + * @powerdown: pll powerdown bit offset > > + * @power_invert: set powerdown bit to power up the PLL > s/set/clear/ ? > It is set. By default set the powerdown bit will powerdown the PLL according to spec. However, for IMX_PLLV3_USB, it's actually power up the PLL, so the power_invert reflect such using. Regards Dong Aisheng > > > Lothar Wa??mann > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel