From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932734AbcFLMZx (ORCPT ); Sun, 12 Jun 2016 08:25:53 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:32832 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753346AbcFLMZv (ORCPT ); Sun, 12 Jun 2016 08:25:51 -0400 Date: Sun, 12 Jun 2016 20:19:47 +0800 From: Dong Aisheng To: Shawn Guo Cc: Dong Aisheng , linux-clk@vger.kernel.org, anson.huang@nxp.com, mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/11] clk: imx6ul: fix pll clock parents Message-ID: <20160612121947.GF32690@shlinux2> References: <1465396420-27064-1-git-send-email-aisheng.dong@nxp.com> <1465396420-27064-7-git-send-email-aisheng.dong@nxp.com> <20160612114353.GE20243@tiger> <20160612115204.GB32690@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160612115204.GB32690@shlinux2> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 12, 2016 at 07:52:04PM +0800, Dong Aisheng wrote: > On Sun, Jun 12, 2016 at 07:43:53PM +0800, Shawn Guo wrote: > > On Wed, Jun 08, 2016 at 10:33:36PM +0800, Dong Aisheng wrote: > > > pllx_bypass_src mux shouldn't be the parent of pllx clock > > > since it's only valid when when pllx BYPASS bit is set. > > > Thus it is actually one parent of pllx_bypass only. > > > > > > Instead, pllx parent should be fixed to osc according to > > > reference manual. > > > Other plls have the same issue. > > > > > > e.g. before fix, the pll tree is: > > > osc 6 6 24000000 0 0 > > > pll1_bypass_src 0 0 24000000 0 0 > > > pll1 0 0 792000000 0 0 > > > pll1_bypass 0 0 792000000 0 0 > > > pll1_sys 0 0 792000000 0 0 > > > > > > After the fix, it's: > > > osc 6 6 24000000 0 0 > > > pll1 0 0 792000000 0 0 > > > pll1_bypass 0 0 792000000 0 0 > > > pll1_sys 0 0 792000000 0 0 > > > > > > Signed-off-by: Dong Aisheng > > > > I squashed 7 ~ 11 into one patch and applied it, thanks. > > > > I'm fine. > Thanks > You probably may need to change the patch title after merge. clk: imx: fix pll clock parents Regards Dong Aisheng > Regards > Dong Aisheng > > > Shawn > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-clk" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html