From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753233AbcFLNaU (ORCPT ); Sun, 12 Jun 2016 09:30:20 -0400 Received: from mail.kernel.org ([198.145.29.136]:56790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbcFLNaS (ORCPT ); Sun, 12 Jun 2016 09:30:18 -0400 Date: Sun, 12 Jun 2016 21:29:28 +0800 From: Shawn Guo To: Dong Aisheng Cc: Dong Aisheng , anson.huang@nxp.com, mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3 Message-ID: <20160612132928.GG20243@tiger> References: <1465396420-27064-1-git-send-email-aisheng.dong@nxp.com> <1465396420-27064-5-git-send-email-aisheng.dong@nxp.com> <20160612113627.GC20243@tiger> <20160612121303.GE32690@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160612121303.GE32690@shlinux2> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 12, 2016 at 08:13:03PM +0800, Dong Aisheng wrote: > I understand your point. > How about using power_bit and powerup_set? > * @power_bit: pll power bit offset I'm fine with the name, but the comment should be fixed, since we are actually using it as a bit mask instead of offset. Shawn > * @powerup_set: set power_bit to power up the PLL