From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbcFMFgG (ORCPT ); Mon, 13 Jun 2016 01:36:06 -0400 Received: from mga02.intel.com ([134.134.136.20]:53438 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbcFMFgE (ORCPT ); Mon, 13 Jun 2016 01:36:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,465,1459839600"; d="scan'208";a="826776982" Date: Mon, 13 Jun 2016 11:12:44 +0530 From: Vinod Koul To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appanad@xilinx.com, moritz.fischer@ettus.com, laurent.pinchart@ideasonboard.com, luis@debethencourt.com, sfr@canb.auug.org.au, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode Message-ID: <20160613054243.GB16910@localhost> References: <1465452132-13512-1-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465452132-13512-1-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2016 at 11:32:12AM +0530, Kedareswara rao Appana wrote: > This patch fixes the below compilation warining. > drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic': > drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used > uninitialized in this function [-Wmaybe-uninitialized] > segment->hw.control |= XILINX_DMA_BD_SOP; > > The start of packet (SOP) should be set to the first segment in the desc > chain not for the last segment of the desc chain. I have applied this after adding Reported by from SFR. You should always give credit to folks who report issues. Thanks -- ~Vinod