From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1422686AbcFMHU7 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jun 2016 03:20:59 -0400
Received: from mail-lf0-f68.google.com ([209.85.215.68]:34262 "EHLO
	mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1030185AbcFMHU4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jun 2016 03:20:56 -0400
Date: Mon, 13 Jun 2016 09:20:50 +0200
From: Henrik Austad <henrik@austad.us>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        alsa-devel@vger.kernel.org, netdev@vger.kernel.org,
        Henrik Austad <haustad@cisco.com>,
        "David S. Miller" <davem@davemloft.net>,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [very-RFC 6/8] Add TSN event-tracing
Message-ID: <20160613072050.GA19180@sisyphus.home.austad.us>
References: <1465686096-22156-1-git-send-email-henrik@austad.us>
 <1465686096-22156-7-git-send-email-henrik@austad.us>
 <20160612125803.27f401cc@gandalf.local.home>
 <20160612212510.GD32724@icarus.home.austad.us>
 <20160612222201.00a8aa4c@grimm.local.home>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp"
Content-Disposition: inline
In-Reply-To: <20160612222201.00a8aa4c@grimm.local.home>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--17pEHd4RhPHOinZp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 12, 2016 at 10:22:01PM -0400, Steven Rostedt wrote:
> On Sun, 12 Jun 2016 23:25:10 +0200
> Henrik Austad <henrik@austad.us> wrote:
>=20
> > > > +#include <linux/if_ether.h>
> > > > +#include <linux/if_vlan.h>
> > > > +/* #include <linux/skbuff.h> */
> > > > +
> > > > +/* FIXME: update to TRACE_CLASS to reduce overhead */ =20
> > >=20
> > > I'm curious to why I didn't do this now. A class would make less
> > > duplication of typing too ;-) =20
> >=20
> > Yeah, I found this in a really great article written by some tracing-du=
de,=20
> > I hear he talks really, really fast!
>=20
> I plead the 5th!
>=20
> >=20
> > https://lwn.net/Articles/381064/
> >=20
> > > > +TRACE_EVENT(tsn_buffer_write,
> > > > +
> > > > +	TP_PROTO(struct tsn_link *link,
> > > > +		size_t bytes),
> > > > +
> > > > +	TP_ARGS(link, bytes),
> > > > +
> > > > +	TP_STRUCT__entry(
> > > > +		__field(u64, stream_id)
> > > > +		__field(size_t, size)
> > > > +		__field(size_t, bsize)
> > > > +		__field(size_t, size_left)
> > > > +		__field(void *, buffer)
> > > > +		__field(void *, head)
> > > > +		__field(void *, tail)
> > > > +		__field(void *, end)
> > > > +		),
> > > > +
> > > > +	TP_fast_assign(
> > > > +		__entry->stream_id =3D link->stream_id;
> > > > +		__entry->size =3D bytes;
> > > > +		__entry->bsize =3D link->used_buffer_size;
> > > > +		__entry->size_left =3D (link->head - link->tail) % link->used_bu=
ffer_size; =20
> > >=20
> > > Move this logic into the print statement, since you save head and tai=
l. =20
> >=20
> > Ok, any particular reason?
>=20
> Because it removes calculations during the trace. The calculations done
> in TP_printk() are done at the time of reading the trace, and
> calculations done in TP_fast_assign() are done during the recording and
> hence adding more overhead to the trace itself.

Aha! that makes sense, thanks!
(/me goes and updates the tracing-part)

-Henrik

--17pEHd4RhPHOinZp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAldeXtIACgkQ6k5VT6v45lmmJwCgwoV2qvp1oqEZC3y+CcunA4vR
taAAnjprjT9Tawz7dspUySmX4AkaxB4S
=804g
-----END PGP SIGNATURE-----

--17pEHd4RhPHOinZp--