From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965238AbcFMH72 (ORCPT ); Mon, 13 Jun 2016 03:59:28 -0400 Received: from verein.lst.de ([213.95.11.211]:39766 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965074AbcFMH70 (ORCPT ); Mon, 13 Jun 2016 03:59:26 -0400 Date: Mon, 13 Jun 2016 09:59:23 +0200 From: Christoph Hellwig To: Sudip Mukherjee , Andrew Morton , linux-kernel@vger.kernel.org, Simran Rai , Christoph Hellwig Subject: Re: [PATCH] dma: remove bad_dma_ops to fix build fail Message-ID: <20160613075923.GA21597@lst.de> References: <1465763104-6227-1-git-send-email-sudipm.mukherjee@gmail.com> <20160612213224.fcjalhwmjqwpjhui@rhwork> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160612213224.fcjalhwmjqwpjhui@rhwork> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote: > Ccing Christoph since his commit introduced bad_dma_ops, and Simran > who wrote that cygnus code. > > I'm thinking that is there to complain loudly when someone is trying > to use dma without HAS_DMA, correct Christoph? Yes. Note that I just refactored the code - before my commit we simply had prototypes for the various DMA API functions that never had an implementation to back them.