From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965054AbcFMJ3u (ORCPT ); Mon, 13 Jun 2016 05:29:50 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33988 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964997AbcFMJ3t (ORCPT ); Mon, 13 Jun 2016 05:29:49 -0400 Date: Mon, 13 Jun 2016 10:29:34 +0100 From: Mark Brown To: Sudip Mukherjee Cc: Andrew Morton , linux-kernel@vger.kernel.org, Simran Rai , Christoph Hellwig Message-ID: <20160613092934.GE2282@sirena.org.uk> References: <1465763104-6227-1-git-send-email-sudipm.mukherjee@gmail.com> <20160612213224.fcjalhwmjqwpjhui@rhwork> <20160613074112.GA2031@sudip-tp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jYUWvSWTDpDT74zJ" Content-Disposition: inline In-Reply-To: <20160613074112.GA2031@sudip-tp> X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 81.128.185.34 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] dma: remove bad_dma_ops to fix build fail X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jYUWvSWTDpDT74zJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 13, 2016 at 08:41:12AM +0100, Sudip Mukherjee wrote: > On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote: > > config SND_SOC_CYGNUS > > tristate "SoC platform audio for Broadcom Cygnus chips" > > depends on ARCH_BCM_CYGNUS || COMPILE_TEST > > + depends on HAS_DMA > > help > > Say Y if you want to add support for ASoC audio on Broadcom > > Cygnus chips (bcm958300, bcm958305, bcm911360) > well, I have been doing the exact same thing for all the drivers that was > failing to build but in my last patch Mark suggested to have stub > implementation in the arch [1]. So while looking for that I noticed > bad_dma_ops is not defined by anyone. So what will you suggest? Right, we've got a couple of obscure architectures with no DMA support which are leading to a constant stream of patches like this that are being triggered by compile coverage stuff. In situations like this we very often provide stubs rather than having to handle this in lots of different places in the code. --jYUWvSWTDpDT74zJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXXnz9AAoJECTWi3JdVIfQGK0H/19Kf48HoXeCKhQRBs08ezME NCtYagw5HhvRGkWn8KzcBPf5ESuqCuyEPcetxpxoNyLSJZeIpzDvwMyFK8JfjGhT NHusQ/ct85fxn0xFgsylnoho1tKO9a6e7bY8/waQbgDdgyqLIidgcRWMUPfvhsGW +mvlNr4EmuSoQBqprbsSDI/giBzvgEX+zgrNKk6troSskbcv4APUVyLrEdYmPI2H oihLhFLQbIJUaIgM0CruGd8gPiEJctdmAcHGpCqy6WHghB4VbdPLSEknbxUnBvyW XW2Dr/AULGsF+/ZgUNpD3/X1sSeBT/9Od2rjsv4Je5w7cmXcwSOo+7IyiJcvA4k= =XEqt -----END PGP SIGNATURE----- --jYUWvSWTDpDT74zJ--