From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965490AbcFMKvT (ORCPT ); Mon, 13 Jun 2016 06:51:19 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33363 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965459AbcFMKvS (ORCPT ); Mon, 13 Jun 2016 06:51:18 -0400 Date: Mon, 13 Jun 2016 11:51:08 +0100 From: Sudip Mukherjee To: Mark Brown Cc: Andrew Morton , linux-kernel@vger.kernel.org, Simran Rai , Christoph Hellwig Subject: Re: [PATCH] dma: remove bad_dma_ops to fix build fail Message-ID: <20160613105108.GA5926@sudip-tp> References: <1465763104-6227-1-git-send-email-sudipm.mukherjee@gmail.com> <20160612213224.fcjalhwmjqwpjhui@rhwork> <20160613074112.GA2031@sudip-tp> <20160613092934.GE2282@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160613092934.GE2282@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2016 at 10:29:34AM +0100, Mark Brown wrote: > On Mon, Jun 13, 2016 at 08:41:12AM +0100, Sudip Mukherjee wrote: > > On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote: > > > > config SND_SOC_CYGNUS > > > tristate "SoC platform audio for Broadcom Cygnus chips" > > > depends on ARCH_BCM_CYGNUS || COMPILE_TEST > > > + depends on HAS_DMA > > > help > > > Say Y if you want to add support for ASoC audio on Broadcom > > > Cygnus chips (bcm958300, bcm958305, bcm911360) > > > well, I have been doing the exact same thing for all the drivers that was > > failing to build but in my last patch Mark suggested to have stub > > implementation in the arch [1]. So while looking for that I noticed > > bad_dma_ops is not defined by anyone. So what will you suggest? > > Right, we've got a couple of obscure architectures with no DMA support > which are leading to a constant stream of patches like this that are > being triggered by compile coverage stuff. In situations like this we > very often provide stubs rather than having to handle this in lots of > different places in the code. Ok, I will do that. But I am seeing arch/m32r/include/asm/m32102.h is defining the DMA Controller registers and also a MAX_DMA_ADDRESS is defined in dma.h. Doesn't that mean that this arch is capable of DMA? Regards Sudip