From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753675AbcFMReU (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jun 2016 13:34:20 -0400
Received: from mga04.intel.com ([192.55.52.120]:9015 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750949AbcFMReT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jun 2016 13:34:19 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,467,1459839600"; 
   d="scan'208";a="986577775"
Date: Mon, 13 Jun 2016 10:38:02 -0700
From: Bin Gao <bin.gao@linux.intel.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        ysiyer <yegnesh.s.iyer@intel.com>,
        Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
        Bin Gao <bin.gao@intel.com>
Subject: Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT
 WhiskeyCove PMIC
Message-ID: <20160613173801.GA202077@worksta>
References: <20160611072531.GB90940@worksta>
 <54020215-86ac-77be-ea4f-19941ed3a176@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54020215-86ac-77be-ea4f-19941ed3a176@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 12, 2016 at 10:13:33AM +0800, Aaron Lu wrote:
> Last time Paul suggests device_initcall instead of module_init here:
> 
> commit 75829dcf10862966f52716f2d67ac1c1b1eb486b
> Author: Paul Gortmaker <paul.gortmaker@windriver.com>
> Date:   Mon Feb 15 00:27:51 2016 -0500
> 
>     drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular
> 
> Perhaps you should do the same.

Thanks Aaron's review.
I just sent out v2 of the patches which addressed your comments.