* [PATCH] [ACPI] Change structure initialisation to C99 style
@ 2016-06-14 8:42 Amitoj Kaur Chawla
2016-06-16 17:39 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2016-06-14 8:42 UTC (permalink / raw)
To: tony.luck, fenghua.yu, linux-ia64, linux-kernel
Cc: julia.lawall, michael.leibowitz, keescook
Replace the in order struct initialisation style with explicit field
style.
The Coccinelle semantic patch used to make this change is as follows:
@decl@
identifier i1,fld;
type T;
field list[n] fs;
@@
struct i1 {
fs
T fld;
...};
@@
identifier decl.i1,i2,decl.fld;
expression e;
position bad.p, bad.fix;
@@
struct i1 i2@p = { ...,
+ .fld = e
- e@fix
,...};
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
arch/ia64/kernel/acpi-ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/ia64/kernel/acpi-ext.c b/arch/ia64/kernel/acpi-ext.c
index bd09bf7..31e331a 100644
--- a/arch/ia64/kernel/acpi-ext.c
+++ b/arch/ia64/kernel/acpi-ext.c
@@ -80,7 +80,7 @@ static acpi_status find_csr_space(struct acpi_resource *resource, void *data)
static acpi_status hp_crs_locate(acpi_handle obj, u64 *base, u64 *length)
{
- struct csr_space space = { 0, 0 };
+ struct csr_space space = { .base = 0, .length = 0 };
acpi_walk_resources(obj, METHOD_NAME__CRS, find_csr_space, &space);
if (!space.length)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [ACPI] Change structure initialisation to C99 style
2016-06-14 8:42 [PATCH] [ACPI] Change structure initialisation to C99 style Amitoj Kaur Chawla
@ 2016-06-16 17:39 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2016-06-16 17:39 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: Tony Luck, Fenghua Yu, linux-ia64, LKML, Julia Lawall, Michael Leibowitz
On Tue, Jun 14, 2016 at 1:42 AM, Amitoj Kaur Chawla
<amitoj1606@gmail.com> wrote:
> Replace the in order struct initialisation style with explicit field
> style.
>
> The Coccinelle semantic patch used to make this change is as follows:
>
> @decl@
> identifier i1,fld;
> type T;
> field list[n] fs;
> @@
>
> struct i1 {
> fs
> T fld;
> ...};
>
> @@
> identifier decl.i1,i2,decl.fld;
> expression e;
> position bad.p, bad.fix;
> @@
>
> struct i1 i2@p = { ...,
> + .fld = e
> - e@fix
> ,...};
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> arch/ia64/kernel/acpi-ext.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/ia64/kernel/acpi-ext.c b/arch/ia64/kernel/acpi-ext.c
> index bd09bf7..31e331a 100644
> --- a/arch/ia64/kernel/acpi-ext.c
> +++ b/arch/ia64/kernel/acpi-ext.c
> @@ -80,7 +80,7 @@ static acpi_status find_csr_space(struct acpi_resource *resource, void *data)
>
> static acpi_status hp_crs_locate(acpi_handle obj, u64 *base, u64 *length)
> {
> - struct csr_space space = { 0, 0 };
> + struct csr_space space = { .base = 0, .length = 0 };
Since these are all initialized to zero, won't "= { };" be easier here?
-Kees
>
> acpi_walk_resources(obj, METHOD_NAME__CRS, find_csr_space, &space);
> if (!space.length)
> --
> 1.9.1
>
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-16 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-14 8:42 [PATCH] [ACPI] Change structure initialisation to C99 style Amitoj Kaur Chawla
2016-06-16 17:39 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).