From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423635AbcFNAqR (ORCPT ); Mon, 13 Jun 2016 20:46:17 -0400 Received: from mail.kernel.org ([198.145.29.136]:51118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422802AbcFNAqM (ORCPT ); Mon, 13 Jun 2016 20:46:12 -0400 Date: Tue, 14 Jun 2016 09:45:59 +0900 From: Masami Hiramatsu To: David Long Cc: Catalin Marinas , Huang Shijie , James Morse , Marc Zyngier , Pratyush Anand , Sandeepa Prabhu , Will Deacon , William Cohen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Steve Capper , Li Bin , Adam Buchbinder , Alex =?UTF-8?B?QmVubsOpZQ==?= , Andrew Morton , Andrey Ryabinin , Ard Biesheuvel , Christoffer Dall , Daniel Thompson , Dave P Martin , Jens Wiklander , Jisheng Zhang , John Blackwood , Mark Rutland , Petr Mladek , Robin Murphy , Suzuki K Poulose , Vladimir Murzin , Yang Shi , Zi Shen Lim , yalin wang , Mark Brown Subject: Re: [PATCH v13 05/10] arm64: Kprobes with single stepping support Message-Id: <20160614094559.51a7865fa30f3f31f6a70e37@kernel.org> In-Reply-To: <575ECFC7.10207@linaro.org> References: <1464924384-15269-1-git-send-email-dave.long@linaro.org> <1464924384-15269-6-git-send-email-dave.long@linaro.org> <20160608100714.4abbcebcf356eb72173d0ce3@kernel.org> <575E3235.1020904@linaro.org> <20160613155017.860097875e8bc86563a065ce@kernel.org> <575ECFC7.10207@linaro.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jun 2016 11:22:47 -0400 David Long wrote: > On 06/13/2016 02:50 AM, Masami Hiramatsu wrote: > > On Mon, 13 Jun 2016 00:10:29 -0400 > > David Long wrote: > > > >>>> --- > >>>> arch/arm64/Kconfig | 1 + > >>>> arch/arm64/include/asm/debug-monitors.h | 5 + > >>>> arch/arm64/include/asm/insn.h | 4 +- > >>>> arch/arm64/include/asm/kprobes.h | 60 ++++ > >>>> arch/arm64/include/asm/probes.h | 44 +++ > >>>> arch/arm64/kernel/Makefile | 1 + > >>>> arch/arm64/kernel/debug-monitors.c | 18 +- > >>>> arch/arm64/kernel/kprobes-arm64.c | 144 +++++++++ > >>>> arch/arm64/kernel/kprobes-arm64.h | 35 +++ > >>>> arch/arm64/kernel/kprobes.c | 526 ++++++++++++++++++++++++++++++++ > >>> > >>> Not sure why kprobes.c and kprobes-arm64.c are splitted. > >>> > >>> > >> > >> This comes from the model of the arm32 kprobes code where handling of > >> the low-level instruction simulation is implemented in separate files > >> for 32-bit vs. thumb instructions. It should make a little more sense > >> in the future when additional instruction simulation code will hopefully > >> be added for those instructions we cannot currently single-step > >> out-of-line. It also probably *could* be merged into one file. > > > > Hmm, at least the name of arch/arm64/kernel/kprobes-arm64.c is > > meaningless. As we've done in x86, I think we can make it > > arch/arm64/kernel/kprobes/decode-insn.{c,h} > > > > I've changed the name to kprobe-decode-insn.[hc], or do you feel > strongly the three kprobes source files in arch/arm64/kernel need their > own subdirectory? Yes, especially when we start working on kprobes-on-ftrace support, it is better to have a separate file for that. Thank you! -- Masami Hiramatsu