From: Ingo Molnar <mingo@kernel.org>
To: WANG Chao <wcwxyz@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched: unlikely corrupted stack end
Date: Tue, 14 Jun 2016 12:26:38 +0200 [thread overview]
Message-ID: <20160614102638.GB13439@gmail.com> (raw)
In-Reply-To: <AAC81E50-769F-4C37-A180-46BAD20EE89E@gmail.com>
* WANG Chao <wcwxyz@gmail.com> wrote:
>
> > 在 2016年6月14日,下午4:56,Ingo Molnar <mingo@kernel.org> 写道:
> >
> >
> > * WANG Chao <wcwxyz@gmail.com> wrote:
> >
> >> unlikely() was dropped in commit ce03e4137bb2 ("sched/core: Drop
> >> unlikely behind BUG_ON()"), but commit 29d6455178a0 ("sched: panic on
> >> corrupted stack end") dropped BUG_ON() and called panic directly.
> >>
> >> Now we should bring unlikely() back for branch prediction. While we're
> >> at it, it's better and cleaner to turn task_stack_end_corrupted() into
> >> inline function.
> >>
> >> Signed-off-by: WANG Chao <wcwxyz@gmail.com>
> >> ---
> >> include/linux/sched.h | 7 +++++--
> >> 1 file changed, 5 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/include/linux/sched.h b/include/linux/sched.h
> >> index 6e42ada26345..797ca1975431 100644
> >> --- a/include/linux/sched.h
> >> +++ b/include/linux/sched.h
> >> @@ -2997,8 +2997,11 @@ static inline unsigned long *end_of_stack(struct task_struct *p)
> >> }
> >>
> >> #endif
> >> -#define task_stack_end_corrupted(task) \
> >> - (*(end_of_stack(task)) != STACK_END_MAGIC)
> >> +
> >> +static inline int task_stack_end_corrupted(struct task_struct *p)
> >> +{
> >> + return unlikely(*(end_of_stack(p)) != STACK_END_MAGIC);
> >> +}
> >
> > The passed in pointer should be const, and the extra parentheses around the
> > end_of_stack() call are not needed anymore (since it's now proper C code now).
>
> end_of_stack() will discard const and cause an compiler warning.
> Should I add const to end_of_stack()?
Yes. Also make sure ia64 still builds and such.
Thanks,
Ingo
next prev parent reply other threads:[~2016-06-14 10:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 6:43 [PATCH] sched: unlikely corrupted stack end WANG Chao
2016-06-14 7:43 ` Ingo Molnar
2016-06-14 8:17 ` Peter Zijlstra
2016-06-14 8:24 ` [PATCH v2] " WANG Chao
2016-06-14 8:56 ` Ingo Molnar
2016-06-14 10:17 ` WANG Chao
2016-06-14 10:26 ` Ingo Molnar [this message]
2016-06-14 16:55 ` WANG Chao
2016-06-15 8:25 ` Ingo Molnar
2016-06-15 8:53 ` [PATCH v3] " WANG Chao
2016-06-14 9:08 ` [PATCH v2] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614102638.GB13439@gmail.com \
--to=mingo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=wcwxyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).