From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
kvm@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH v8 0/5] skb_array: array based FIFO for skbs
Date: Tue, 14 Jun 2016 13:56:59 +0200 [thread overview]
Message-ID: <20160614135659.0cb9f2ff@redhat.com> (raw)
In-Reply-To: <20160613235426-mutt-send-email-mst@redhat.com>
On Mon, 13 Jun 2016 23:54:26 +0300 "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> Jesper, Jason, I know that both of you tested this,
> please post Tested-by tags for whatever was tested.
Yes, I tested this via "external" kernel modules, not your framework.
I have verified that this V8 patchset is equivalent, to what I have in:
https://github.com/netoptimizer/prototype-kernel/ (at 81ca09c2a945)
> changes since v7
> fix typos noticed by Jesper Brouer
You also fixed a missing _bh ... I verified you also included this fix ;-)
https://github.com/netoptimizer/prototype-kernel/commit/24da4f495bb
> changes since v6
> resize implemented. peek/full calls are no longer lockless
>
> replaced _FIELD macros with _CALL which invoke a function
> on the pointer rather than just returning a value
>
> destroy now scans the array and frees all queued skbs
>
> changes since v5
> implemented a generic ptr_ring api, and
> made skb_array a type-safe wrapper
> apis for taking the spinlock in different contexts
> following expected usecase in tun
Tested-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-06-14 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 20:54 [PATCH v8 0/5] skb_array: array based FIFO for skbs Michael S. Tsirkin
2016-06-14 11:56 ` Jesper Dangaard Brouer [this message]
2016-06-15 20:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614135659.0cb9f2ff@redhat.com \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).