* [PATCH 1/1] net: rsi: eliminate superfluous NULL check
@ 2016-05-17 22:30 Heinrich Schuchardt
2016-05-19 18:31 ` David Miller
2016-06-14 14:18 ` [1/1] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2016-05-17 22:30 UTC (permalink / raw)
To: Kalle Valo
Cc: Nicholas Mc Guire, Johannes Berg, linux-wireless, netdev,
linux-kernel, Heinrich Schuchardt
msg is dereferenced before checking against NULL, e.g.
when assigning pad_bytes.
Remove the superfluous check in function rsi_mgmt_pkt_to_core.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index 40658b6..35c14cc 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -398,7 +398,7 @@ static int rsi_mgmt_pkt_to_core(struct rsi_common *common,
return -ENOLINK;
msg_len -= pad_bytes;
- if ((msg_len <= 0) || (!msg)) {
+ if (msg_len <= 0) {
rsi_dbg(MGMT_RX_ZONE,
"%s: Invalid rx msg of len = %d\n",
__func__, msg_len);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: rsi: eliminate superfluous NULL check
2016-05-17 22:30 [PATCH 1/1] net: rsi: eliminate superfluous NULL check Heinrich Schuchardt
@ 2016-05-19 18:31 ` David Miller
2016-06-14 14:18 ` [1/1] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-05-19 18:31 UTC (permalink / raw)
To: xypron.glpk
Cc: kvalo, hofrat, johannes.berg, linux-wireless, netdev, linux-kernel
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Wed, 18 May 2016 00:30:41 +0200
> msg is dereferenced before checking against NULL, e.g.
> when assigning pad_bytes.
> Remove the superfluous check in function rsi_mgmt_pkt_to_core.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
I'll let the wireless folks pick this up.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [1/1] rsi: eliminate superfluous NULL check
2016-05-17 22:30 [PATCH 1/1] net: rsi: eliminate superfluous NULL check Heinrich Schuchardt
2016-05-19 18:31 ` David Miller
@ 2016-06-14 14:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-06-14 14:18 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Nicholas Mc Guire, Johannes Berg, linux-wireless, netdev,
linux-kernel, Heinrich Schuchardt
Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> msg is dereferenced before checking against NULL, e.g.
> when assigning pad_bytes.
> Remove the superfluous check in function rsi_mgmt_pkt_to_core.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Thanks, 1 patch applied to wireless-drivers-next.git:
9b648d788d78 rsi: eliminate superfluous NULL check
--
Sent by pwcli
https://patchwork.kernel.org/patch/9115441/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-14 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-17 22:30 [PATCH 1/1] net: rsi: eliminate superfluous NULL check Heinrich Schuchardt
2016-05-19 18:31 ` David Miller
2016-06-14 14:18 ` [1/1] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).