From: Mel Gorman <mgorman@techsingularity.net>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes
Date: Tue, 14 Jun 2016 15:52:58 +0100 [thread overview]
Message-ID: <20160614145258.GD1868@techsingularity.net> (raw)
In-Reply-To: <02ff01d1c48d$78112f40$68338dc0$@alibaba-inc.com>
On Sun, Jun 12, 2016 at 05:33:24PM +0800, Hillf Danton wrote:
> > - /*
> > - * We put equal pressure on every zone, unless one zone has way too
> > - * many pages free already. The "too many pages" is defined as the
> > - * high wmark plus a "gap" where the gap is either the low
> > - * watermark or 1% of the zone, whichever is smaller.
> > - */
> > - balance_gap = min(low_wmark_pages(zone), DIV_ROUND_UP(
> > - zone->managed_pages, KSWAPD_ZONE_BALANCE_GAP_RATIO));
> > + nr_to_reclaim += max(high_wmark_pages(zone), SWAP_CLUSTER_MAX);
> > + }
>
> Missing sc->nr_to_reclaim = nr_to_reclaim; ?
>
Yes. It may explain why I saw lower than expected kswapd in more
detailed tests recently. Thanks.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-06-14 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <02fe01d1c48b$c44e9e80$4cebdb80$@alibaba-inc.com>
2016-06-12 9:33 ` [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes Hillf Danton
2016-06-14 14:52 ` Mel Gorman [this message]
[not found] <071801d1cc5c$245087d0$6cf19770$@alibaba-inc.com>
2016-06-22 8:42 ` Hillf Danton
2016-06-23 11:31 ` Mel Gorman
2016-06-21 14:15 [PATCH 00/27] Move LRU page reclaim from zones to nodes v7 Mel Gorman
2016-06-21 14:15 ` [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2016-06-09 18:04 [PATCH 00/27] Move LRU page reclaim from zones to nodes v6 Mel Gorman
2016-06-09 18:04 ` [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes Mel Gorman
2016-06-15 14:23 ` Vlastimil Babka
2016-04-15 9:13 [PATCH 00/27] Move LRU page reclaim from zones to nodes v5 Mel Gorman
2016-04-15 9:13 ` [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes Mel Gorman
2016-04-28 8:36 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614145258.GD1868@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).