From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752128AbcFNOxG (ORCPT ); Tue, 14 Jun 2016 10:53:06 -0400 Received: from outbound-smtp08.blacknight.com ([46.22.139.13]:44634 "EHLO outbound-smtp08.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbcFNOxC (ORCPT ); Tue, 14 Jun 2016 10:53:02 -0400 Date: Tue, 14 Jun 2016 15:52:58 +0100 From: Mel Gorman To: Hillf Danton Cc: linux-kernel , linux-mm@kvack.org Subject: Re: [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes Message-ID: <20160614145258.GD1868@techsingularity.net> References: <02fe01d1c48b$c44e9e80$4cebdb80$@alibaba-inc.com> <02ff01d1c48d$78112f40$68338dc0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <02ff01d1c48d$78112f40$68338dc0$@alibaba-inc.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 12, 2016 at 05:33:24PM +0800, Hillf Danton wrote: > > - /* > > - * We put equal pressure on every zone, unless one zone has way too > > - * many pages free already. The "too many pages" is defined as the > > - * high wmark plus a "gap" where the gap is either the low > > - * watermark or 1% of the zone, whichever is smaller. > > - */ > > - balance_gap = min(low_wmark_pages(zone), DIV_ROUND_UP( > > - zone->managed_pages, KSWAPD_ZONE_BALANCE_GAP_RATIO)); > > + nr_to_reclaim += max(high_wmark_pages(zone), SWAP_CLUSTER_MAX); > > + } > > Missing sc->nr_to_reclaim = nr_to_reclaim; ? > Yes. It may explain why I saw lower than expected kswapd in more detailed tests recently. Thanks. -- Mel Gorman SUSE Labs