From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbcFNPXt (ORCPT ); Tue, 14 Jun 2016 11:23:49 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37402 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbcFNPXs (ORCPT ); Tue, 14 Jun 2016 11:23:48 -0400 Date: Tue, 14 Jun 2016 16:23:18 +0100 From: Mark Brown To: Srinivas Kandagatla Cc: alsa-devel@alsa-project.org, Rob Herring , Mark Rutland , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kwestfie@codeaurora.org, plai@codeaurora.org, linux-arm-msm@vger.kernel.org Message-ID: <20160614152318.GR2282@sirena.org.uk> References: <1465582725-30183-1-git-send-email-srinivas.kandagatla@linaro.org> <1465582725-30183-2-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="htVlOAOs/VIaEhiC" Content-Disposition: inline In-Reply-To: <1465582725-30183-2-git-send-email-srinivas.kandagatla@linaro.org> X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 81.128.185.34 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 1/2] ASoC: msm8916: Add codec Device Tree bindings. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --htVlOAOs/VIaEhiC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 10, 2016 at 07:18:44PM +0100, Srinivas Kandagatla wrote: > +Codec IP is divided into two parts, first analog which is integrated in pmic pm8916 > +and secondly digital part which is integrated into application processor. Codec register > +controls are also split across pmic an lpass. Analog part is controlled via spmi bus to pmic. Please keep things wrapped at less than 80 columns. > + - interrupt-parent : The parent interrupt controller. > + - interrupts: List of interrupts in given SPMI peripheral. > + - interrupt-names: Names specified to above list of interrupts in same > + order. List of supported interrupt names are: > + "spk_cnp_int" - Speaker click and pop interrupt Please format this more clearly so these don't look like properties, more indentation would be good. > + - vddio-supply: phandle to VDD_CDC_IO regulator device tree node. > + - vdd-tx-rx-supply: phandle to VDD_CDC_TX/RX/CX regulator device tree node. You should name the supplies with the same name as the datasheet uses. --htVlOAOs/VIaEhiC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXYCFiAAoJECTWi3JdVIfQtQwH/iCnUxV1XkjcxF/Z3UQv1Y5Z h2EG3PriI+QcxTMZw6dMj63DLsR61voL+RScWtAUmW6kx4qDjaSCU7qpurxJ2eCO YtM0oyygIAJER52ReFK8U36AwlGbz+q8w2tKtqFxJve5FAD6EV1Jz/RRWesc094C RHbB69Ibu2dEEWgZaDTiQdnPd5kHqTvXFV2ztjTMeXllhZWHLgA14UWpZ2+MNkAH bS0UDcy6QPs7FIZbCQT2X/Eipi5Q478k2E7MN2Yzi1sFsjtf9TAzlFCpfoyxdM3w /5uMT5xO6Pj367z/kIN/9XEXMYzFZ2iHbiiS54YwBjE3I5ae2RBjJ76d3EvX6Ac= =Vr3l -----END PGP SIGNATURE----- --htVlOAOs/VIaEhiC--