From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752550AbcFNQ1E (ORCPT ); Tue, 14 Jun 2016 12:27:04 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33789 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbcFNQ1B (ORCPT ); Tue, 14 Jun 2016 12:27:01 -0400 Date: Tue, 14 Jun 2016 18:26:56 +0200 From: Daniel Vetter To: Yakir Yang Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Javier Martinez Canillas , =?iso-8859-1?Q?St=E9phane?= Marchesin , Tomasz Figa , David Airlie , daniel.vetter@ffwll.ch, Thierry Reding , dianders@chromium.org, Krzysztof Kozlowski , emil.l.velikov@gmail.com, Dan Carpenter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 07/10] drm/bridge: analogix_dp: passing the connector as an argument in .get_modes() Message-ID: <20160614162656.GA1338@phenom.ffwll.local> Mail-Followup-To: Yakir Yang , Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Javier Martinez Canillas , =?iso-8859-1?Q?St=E9phane?= Marchesin , Tomasz Figa , David Airlie , Thierry Reding , dianders@chromium.org, Krzysztof Kozlowski , emil.l.velikov@gmail.com, Dan Carpenter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <1465904789-1021-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465904789-1021-1-git-send-email-ykk@rock-chips.com> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2016 at 07:46:29PM +0800, Yakir Yang wrote: > It's better to pass the connector to platform driver in .get_modes() > callback, just like what the .get_modes() helper function designed. > > Signed-off-by: Yakir Yang Also please drop the analogix prefix from the subject, this is for all drm_bridge drivers. -Daniel > --- > Changes in v3: > - Avoid to change any internal driver state in .mode_valid interface. (Tomasz, reviewed at Google Gerrit) > [https://chromium-review.googlesource.com/#/c/346318/10/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@113] > > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +- > drivers/gpu/drm/exynos/exynos_dp.c | 4 ++-- > include/drm/bridge/analogix_dp.h | 3 ++- > 3 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 4a1b3b8..1a890fa 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -938,7 +938,7 @@ int analogix_dp_get_modes(struct drm_connector *connector) > num_modes += drm_panel_get_modes(dp->plat_data->panel); > > if (dp->plat_data->get_modes) > - num_modes += dp->plat_data->get_modes(dp->plat_data); > + num_modes += dp->plat_data->get_modes(dp->plat_data, connector); > > return num_modes; > } > diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c > index 468498e..8a555ed 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp.c > +++ b/drivers/gpu/drm/exynos/exynos_dp.c > @@ -67,10 +67,10 @@ static int exynos_dp_poweroff(struct analogix_dp_plat_data *plat_data) > return exynos_dp_crtc_clock_enable(plat_data, false); > } > > -static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data) > +static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data, > + struct drm_connector *connector) > { > struct exynos_dp_device *dp = to_dp(plat_data); > - struct drm_connector *connector = &dp->connector; > struct drm_display_mode *mode; > int num_modes = 0; > > diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix_dp.h > index 82b8135..181db09 100644 > --- a/include/drm/bridge/analogix_dp.h > +++ b/include/drm/bridge/analogix_dp.h > @@ -34,7 +34,8 @@ struct analogix_dp_plat_data { > int (*power_off)(struct analogix_dp_plat_data *); > int (*attach)(struct analogix_dp_plat_data *, struct drm_bridge *, > struct drm_connector *); > - int (*get_modes)(struct analogix_dp_plat_data *); > + int (*get_modes)(struct analogix_dp_plat_data *, > + struct drm_connector *); > }; > > int analogix_dp_resume(struct device *dev); > -- > 1.9.1 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch