From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbcFNWiP (ORCPT ); Tue, 14 Jun 2016 18:38:15 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35018 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbcFNWiN (ORCPT ); Tue, 14 Jun 2016 18:38:13 -0400 Date: Tue, 14 Jun 2016 17:38:10 -0500 From: Rob Herring To: Xing Zheng Cc: linux-rockchip@lists.infradead.org, dianders@chromium.org, heiko@sntech.de, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Message-ID: <20160614223810.GA7925@rob-hp-laptop> References: <1465807339-1100-1-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465807339-1100-1-git-send-email-zhengxing@rock-chips.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: > Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219) > on the RK3399 GRU boards, this patch can help us to support these codecs. > > Signed-off-by: Xing Zheng > --- > > Changes in v5: > - fix the build warning for missing I2C/CLKDEV_LOOKUP dependency > > Changes in v4: > - the compatible name needs to be based on a single reference design, > and the name of the board is called "GRU" > - use one i2sX card "rockchip,cpu = <&i2s0>" instead of array that is > based on GRU > - rename DOC to rockchip,rk3399-gru-sound.txt > - rename compatible to rockchip,rk3399-gru-sound > - rename source code to rk3399_gru_sound.c > > Changes in v3: > - rename DOC to rockchip,rk3399-max98357a-rt5514-da7219.txt > - rename compatible to rockchip,rk3399-max98357a-rt5514-da7219 > - rename source code to rk3399_max98357a_rt5514_da7219.c > > Changes in v2: > - use the FS 256 to set mclks of the max98357a and rt5514 danamically > - add more sample rate for da7219 > > .../bindings/sound/rockchip,rk3399-gru-sound.txt | 15 + > sound/soc/rockchip/Kconfig | 11 + > sound/soc/rockchip/Makefile | 2 + > sound/soc/rockchip/rk3399_gru_sound.c | 339 ++++++++++++++++++++ > 4 files changed, 367 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt > create mode 100644 sound/soc/rockchip/rk3399_gru_sound.c > > diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt b/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt > new file mode 100644 > index 0000000..f19b6c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt > @@ -0,0 +1,15 @@ > +ROCKCHIP with MAX98357A/RT5514/DA7219 codecs on GRU boards > + > +Required properties: > +- compatible: "rockchip,rk3399-gru-sound" > +- rockchip,cpu: The phandle of the Rockchip I2S controller that's > + connected to the codecs > +- rockchip,codec: The phandle of the MAX98357A/RT5514/DA7219 codecs > + > +Example: > + > +sound { > + compatible = "rockchip,rk3399-gru-sound"; > + rockchip,cpu = <&i2s0>; > + rockchip,codec = <&max98357a &rt5514 &da7219>; These seem fairly standard though a variety of versions in the bindings. Can we use audio-codec and audio-cpu (or cpu or audio-dai) here? Mark? Rob