From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016AbcFOIXi (ORCPT ); Wed, 15 Jun 2016 04:23:38 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36567 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbcFOIXg (ORCPT ); Wed, 15 Jun 2016 04:23:36 -0400 Date: Wed, 15 Jun 2016 09:23:26 +0100 From: Sudip Mukherjee To: Dan Williams Cc: Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] dax: use devm_add_action_or_reset Message-ID: <20160615082326.GA1764@sudip-tp> References: <1465742896-5841-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2016 at 04:28:43PM -0700, Dan Williams wrote: > On Sun, Jun 12, 2016 at 7:48 AM, Sudip Mukherjee > wrote: > > If devm_add_action() fails we are explicitly calling the cleanup to free > > the resources allocated. Lets use the helper devm_add_action_or_reset() > > and return directly in case of error, as we know that the cleanup > > function has been already called by the helper if there was any error. > > > > Signed-off-by: Sudip Mukherjee > > Reviewed-by: Dan Williams > > > --- > > > > There is no maintainer mentioned for this driver, so not sure who should > > this patch go through. > > *raises hand*, I'll make sure MAINTAINERS gets updated, for this one > it seems Andrew has already taken it. I notice that drivers/nvdimm/ > could use the same cleanup. I'll take a look unless you beat me to > it. I will give you an advantage in the race, i will not see that before saturday. :) Regards Sudip