From: Andrew Morton <akpm@linux-foundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Minchan Kim <minchan@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Mel Gorman <mgorman@techsingularity.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: compaction: fix dummy declarations
Date: Wed, 15 Jun 2016 14:48:25 -0700 [thread overview]
Message-ID: <20160615144825.79274c2b6ac1625eb42002d1@linux-foundation.org> (raw)
In-Reply-To: <20160615213929.36528-1-arnd@arndb.de>
On Wed, 15 Jun 2016 23:39:12 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> We get a build error in several test builds after a recent code rework:
>
> In file included from include/linux/balloon_compaction.h:48:0,
> from mm/balloon_compaction.c:11:
> include/linux/compaction.h:237:122: error: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> The patch that likely introduced the problem added a forward declaration
> for 'struct node' in linux/compaction.h, but only in one of two instances.
>
> This moves the declaration out of the #ifdef so we always get it.
http://ozlabs.org/~akpm/mmots/broken-out/mm-balloon-use-general-non-lru-movable-page-feature-fix.patch
should fix this. I guess I should do another -mm.
next prev parent reply other threads:[~2016-06-15 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 21:39 [PATCH] mm: compaction: fix dummy declarations Arnd Bergmann
2016-06-15 21:48 ` Andrew Morton [this message]
2016-06-15 23:30 ` Minchan Kim
2016-06-16 21:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615144825.79274c2b6ac1625eb42002d1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).