From: Arnd Bergmann <arnd@arndb.de>
To: Michal Marek <mmarek@suse.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH v2 00/11] Kbuild: fix -Wmissing-include-path warnings
Date: Wed, 15 Jun 2016 17:45:42 +0200 [thread overview]
Message-ID: <20160615154553.3177021-1-arnd@arndb.de> (raw)
This warning is enabled at "make W=1" level, and found a bunch of
actual problems in code that adds -I flags to nonexisting directories.
All of these are harmless, but clearly wrong.
Kbuild itself also adds a bunch of extra directories, including in
some cases those outside of the kernel tree (e.g. ../../include),
which can have surprising consequences.
This series fixes all the warnings I found with -Wmissing-include-dirs
enabled on ARM randconfigs and x86 allmodconfig. The non-Kbuild
patches can all be applied independently, while we probably want
the Kbuild stuff to be kept as a series, if we decide to merge them.
I have added my test patch at the end, mainly to see if the Kbuild
bot finds any other warnings on additional architectures.
Arnd
Arnd Bergmann (11):
Kbuild: don't add ../../ to include path
Kbuild: avoid duplicate include path
Kbuild: always prefix objtree in LINUXINCLUDE
Kbuild: arch: look for generated headers in obtree
Kbuild: don't add obj tree in additional includes
ARM: don't include removed directories
ARM: hide mach-*/ include for ARM_SINGLE_ARMV7M
drm: amd: remove broken include path
net: skfb: remove obsolete -I cflag
rtlwifi: don't add include path for rtl8188ee
[EXPERIMENTAL] Kbuild: enable -Wmissing-include-dirs by default
Makefile | 16 ++++++++++------
arch/alpha/boot/Makefile | 2 +-
arch/arm/Makefile | 2 ++
arch/arm/mach-mvebu/Makefile | 3 +--
arch/arm/mach-realview/Makefile | 3 +--
arch/arm/mach-s5pv210/Makefile | 2 +-
arch/powerpc/boot/Makefile | 2 +-
arch/powerpc/kvm/Makefile | 2 +-
arch/s390/boot/compressed/Makefile | 4 ++--
arch/um/Makefile | 4 ++--
arch/x86/boot/Makefile | 2 +-
arch/x86/realmode/rm/Makefile | 2 +-
drivers/gpu/drm/amd/acp/Makefile | 2 --
drivers/net/fddi/skfp/Makefile | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/Makefile | 2 +-
scripts/Kbuild.include | 2 +-
scripts/Makefile.lib | 7 ++++---
17 files changed, 31 insertions(+), 28 deletions(-)
--
2.9.0
next reply other threads:[~2016-06-15 15:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 15:45 Arnd Bergmann [this message]
2016-06-15 15:45 ` [PATCH v2 01/11] Kbuild: don't add ../../ to include path Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 02/11] Kbuild: avoid duplicate " Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 03/11] Kbuild: always prefix objtree in LINUXINCLUDE Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 04/11] Kbuild: arch: look for generated headers in obtree Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes Arnd Bergmann
2016-07-18 20:14 ` Michal Marek
2016-07-19 8:31 ` Arnd Bergmann
2016-07-19 14:33 ` Kalle Valo
2016-07-19 15:38 ` Arnd Bergmann
2016-07-19 18:07 ` Kalle Valo
2016-06-15 15:45 ` [PATCH v2 06/11] ARM: don't include removed directories Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 07/11] ARM: hide mach-*/ include for ARM_SINGLE_ARMV7M Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 08/11] drm: amd: remove broken include path Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 09/11] net: skfb: remove obsolete -I cflag Arnd Bergmann
2016-06-16 5:06 ` David Miller
2016-06-15 15:45 ` [PATCH v2 10/11] rtlwifi: don't add include path for rtl8188ee Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 11/11] [EXPERIMENTAL] Kbuild: enable -Wmissing-include-dirs by default Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615154553.3177021-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).