From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753680AbcFOUwa (ORCPT ); Wed, 15 Jun 2016 16:52:30 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56211 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753203AbcFOUw0 (ORCPT ); Wed, 15 Jun 2016 16:52:26 -0400 Date: Wed, 15 Jun 2016 22:52:23 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Bernhard Nortmann , Julian Calaby , =?utf-8?B?572X57+8?= , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree , "Mailing List, Arm" , "linux-kernel@vger.kernel.org" , linux-sunxi Subject: Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board Message-ID: <20160615205223.GC5144@lukather> References: <20160602023623.5761-1-luoyi.ly@gmail.com> <20160602081638.GG4908@lukather> <574FF94B.3020309@web.de> <20160610093851.GQ5242@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O3RTKUHj+75w1tg5" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --O3RTKUHj+75w1tg5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Chen-Yu, On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote: > On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard > wrote: > > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote: > >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard: > >> >[...] > >> >Yes, everything that is shared with the banana-pro (which, judging > >> >from Bernhard, is pretty much everything but a GPIO) should be merged > >> >in the banapro DT. > >> > > >> >Maxime > >> > > >> > >> Don't take my word for granted, as I do not own this hardware or know = it > >> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" a= re > >> very similar, but if in doubt the information form the wiki should be > >> verified. > > > > Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much > > more than I do. >=20 > I did a comparison of the "Banana Pro" vs the "BPi-M1+". >=20 > The differences are similar to what we have with any other development > board, say the Cubietruck: >=20 > - A different WiFi chip is used, and the BT part is not hooked up. > - Different GPIOs for external power regulator/switches > - Different GPIOs for LEDs > - Different peripherals exposed on the headers. >=20 > IMO There's no need to merge or have a common .dtsi for the two boards. Ok. > They (and all the other development boards) look similar because > everyone is following the basic set by Allwinner's reference design, > like which MMC controller and pins are used for SD/MMC, which ones > are used for SDIO-based WiFi, and so on. >=20 > I did a version completely from scratch using just the schematics: >=20 > https://github.com/wens/linux/commits/bpi-m1-plus So, what do you mean by that? Do you have some comments on that patch, or should I merge it, and you'll post your additions on top of it? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --O3RTKUHj+75w1tg5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXYcAHAAoJEBx+YmzsjxAgCh8QAIsc6ib4fbFfwz0D50Ro9l5l l5/9kj3M1+pqZMu9KiUXeLD4RjSfaFluAujF+Yf/EikhIKzx4LwLMS8OD1SNmNST ju8XQ7gpUx8ntssiNf6BB6qwhMRBnyRr9CWHpSY9Ir73/KMY2G/BJ19hYaLCEhaL P6wQ3Vc3PVBoZMAQHngQnFOXgzKxETqNc8GmTb3maCDgkxAkh3qNwCRtPno2kAyv DpjvCq5YJ5ZUEai+sCyLHxxpcoazEIKadBxiUBumpfQWKMRCl+02Zd/yJw3PB9Gc IqsE7nkijkBIsruLgR68SjLbIx5C0LV82sJlXLuQbaiPakzCqO5nx6P2YrmwpXLI SoVLDKEEVig2n7Hn8e6AOBrorOLq3Y+VuEXZsC0V2MMLXYiJ9ybqPvUbR5E6l9mH JVPgBsYsyADq9caoQ3rdPt3gBQEnwWazw1HRuv/nw30a/gIv+1ZXyGXd/0XQZZ8y NoGFpUXaHKroF6VSXs0hihYVMOqxVX7gG3YvCCteDGMfzK7e+1TqvN/JMS4hG98+ nRX/NMYt75hTZLr1627hE7ymtLt5nmmFo1ESg6rGmi7g9eCNP23cfyj+14N0rmGQ 6c8Yb+5hL7sIwtl6V9itXyFXoC/h+AgDIdQIkxUaQFTNu6W7r6lAOD7GCx/p2EFz bc6fEnvJjbmzZ7NChYt/ =Wvod -----END PGP SIGNATURE----- --O3RTKUHj+75w1tg5--