From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933041AbcFOVue (ORCPT ); Wed, 15 Jun 2016 17:50:34 -0400 Received: from mail.skyhub.de ([78.46.96.112]:35108 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932327AbcFOVua (ORCPT ); Wed, 15 Jun 2016 17:50:30 -0400 Date: Wed, 15 Jun 2016 23:50:26 +0200 From: Borislav Petkov To: Tony Battersby Cc: Borislav Petkov , Yazen Ghannam , linux-edac@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: lk 4.7 regression: EDAC, amd64_edac: Drop pci_register_driver() use Message-ID: <20160615215026.GL30309@pd.tnic> References: <5761BEB0.9000807@cybernetics.com> <20160615211249.GK30309@pd.tnic> <5761CC0E.4040102@cybernetics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5761CC0E.4040102@cybernetics.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 05:43:42PM -0400, Tony Battersby wrote: > With that patch applied, modprobe amd64_edac_mod correctly reports "No > such device" and everything is fine. Good, thanks! I'll add your Tested-by to the fix, if you don't mind. > I also get a new line in dmesg on boot: > > amd_nb: Cannot enumerate AMD northbridges Yeah, comes from init_amd_nbs(). I guess I can remove that pr_notice() as it is unnecessary noise on distro kernels which enable AMD_NB. > You might want to consider using -ENODEV instead of -1 for callers such > as init_amd_nbs() that use the error value. Yeah, already changed to -ENODEV :-) Thanks for reporting and testing! -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.