From: David Miller <davem@davemloft.net>
To: vpalatin@chromium.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, dianders@chromium.org, peppe.cavallaro@st.com,
heiko@sntech.de, zhengsq@rock-chips.com
Subject: Re: [PATCH v2 0/3] net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288
Date: Thu, 16 Jun 2016 14:15:14 -0700 (PDT) [thread overview]
Message-ID: <20160616.141514.2135278107149916159.davem@davemloft.net> (raw)
In-Reply-To: <cover.1466015458.git.vpalatin@chromium.org>
From: Vincent Palatin <vpalatin@chromium.org>
Date: Wed, 15 Jun 2016 11:32:20 -0700
> In order to support Wake-On-Lan when using the RK3288 integrated MAC
> (with an external RGMII PHY), we need to avoid shutting down the regulator
> of the external PHY when the MAC is suspended as it's currently done in the MAC
> platform code.
> As a first step, create independant callbacks for suspend/resume rather than
> re-using exit/init callbacks. So the dwmac platform driver can behave differently
> on suspend where it might skip shutting the PHY and at module unloading.
> Then update the dwmac-rk driver to switch off the PHY regulator only if we are
> not planning to wake up from the LAN.
> Finally add the PMT interrupt to the MAC device tree configuration, so we can
> wake up the core from it when the PHY has received the magic packet.
>
> Changes since v1:
> * rename 'powered_down' variable into 'suspended'.
> * fix the logic recording the PHY suspended state according to Heiko comments.
Series applied to net-next, thanks.
next prev parent reply other threads:[~2016-06-16 21:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 17:29 [PATCH] net: stmmac: dwmac-rk: keep PHY up for WoL Vincent Palatin
2016-06-06 20:45 ` Heiko Stübner
2016-06-06 21:00 ` Vincent Palatin
2016-06-07 7:23 ` Giuseppe CAVALLARO
2016-06-08 22:25 ` Vincent Palatin
2016-06-09 0:17 ` Andrew Lunn
2016-06-09 23:00 ` Vincent Palatin
2016-06-10 12:29 ` Giuseppe CAVALLARO
2016-06-11 1:00 ` net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288 Vincent Palatin
2016-06-11 1:00 ` [PATCH 1/3] net: stmmac: allow to split suspend/resume from init/exit callbacks Vincent Palatin
2016-06-11 1:16 ` David Miller
2016-06-11 1:00 ` [PATCH 2/3] net: stmmac: dwmac-rk: keep the PHY up for WoL Vincent Palatin
2016-06-11 1:57 ` Heiko Stuebner
2016-06-15 16:03 ` Vincent Palatin
2016-06-15 18:32 ` [PATCH v2 0/3] net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288 Vincent Palatin
2016-06-15 18:32 ` [PATCH v2 1/3] net: stmmac: allow to split suspend/resume from init/exit callbacks Vincent Palatin
2016-06-15 18:32 ` [PATCH v2 2/3] net: stmmac: dwmac-rk: keep the PHY up for WoL Vincent Palatin
2016-06-15 18:32 ` [PATCH v2 3/3] ARM: dts: rockchip: add interrupt for Wake-on-Lan on RK3288 Vincent Palatin
2016-06-16 21:15 ` David Miller [this message]
2016-06-11 1:00 ` [PATCH " Vincent Palatin
2016-06-11 1:16 ` net: stmmac: dwmac-rk: fixes " David Miller
2016-06-13 6:46 ` Giuseppe CAVALLARO
2016-06-15 17:04 ` Vincent Palatin
2016-06-16 13:37 ` Giuseppe CAVALLARO
2016-06-16 14:51 ` Vincent Palatin
2016-06-17 5:38 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616.141514.2135278107149916159.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vpalatin@chromium.org \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).