From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753742AbcFPAU3 (ORCPT ); Wed, 15 Jun 2016 20:20:29 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45694 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819AbcFPAU0 (ORCPT ); Wed, 15 Jun 2016 20:20:26 -0400 Date: Wed, 15 Jun 2016 17:20:24 -0700 From: Stephen Boyd To: Linus Walleij Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, Bjorn Andersson , stable@vger.kernel.org Subject: Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 Message-ID: <20160616002024.GO28218@codeaurora.org> References: <1465945346-29298-1-git-send-email-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465945346-29298-1-git-send-email-linus.walleij@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15, Linus Walleij wrote: > @@ -426,10 +447,11 @@ static irqreturn_t qcom_rpm_ack_interrupt(int irq, void *dev) > u32 ack; > int i; > > - ack = readl_relaxed(RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT)); > - for (i = 0; i < RPM_SELECT_SIZE; i++) > - writel_relaxed(0, RPM_CTRL_REG(rpm, RPM_ACK_SELECTOR + i)); > - writel(0, RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT)); > + ack = readl_relaxed(RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off)); > + for (i = 0; i < rpm->data->sel_size; i++) > + writel_relaxed(0, > + RPM_CTRL_REG(rpm, rpm->data->ack_sel_off + i)); > + writel(0, RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off)); Does the ack size vary though? I thought that was always 7. It seems that really only the request selector size varies? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project