From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752838AbcFPGda (ORCPT ); Thu, 16 Jun 2016 02:33:30 -0400 Received: from mail-bn1bon0067.outbound.protection.outlook.com ([157.56.111.67]:18304 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751300AbcFPGd2 (ORCPT ); Thu, 16 Jun 2016 02:33:28 -0400 X-Greylist: delayed 906 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Jun 2016 02:33:28 EDT Authentication-Results: spf=none (sender IP is 165.204.84.21) smtp.mailfrom=amd.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=permerror action=none header.from=amd.com; Date: Thu, 16 Jun 2016 13:38:14 +0800 From: Huang Rui To: Vince Weaver CC: Borislav Petkov , Thomas Gleixner , "Peter Zijlstra" , Ingo Molnar , "Andy Lutomirski" , Robert Richter , "Jacob Shin" , Arnaldo Carvalho de Melo , Kan Liang , , , Suravee Suthikulpanit , Aravind Gopalakrishnan , Borislav Petkov , Guenter Roeck , Fengguang Wu Subject: Re: [REDO PATCH v7] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Message-ID: <20160616053802.GA7810@hr-amur2> References: <1457502306-2559-1-git-send-email-ray.huang@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.21;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(428002)(199003)(189002)(24454002)(97756001)(11100500001)(1076002)(50466002)(2171001)(87936001)(33716001)(19580405001)(50986999)(86362001)(5008740100001)(46406003)(83506001)(23726003)(6806005)(8676002)(586003)(246002)(2950100001)(77096005)(9686002)(54356999)(8936002)(106466001)(105586002)(356003)(26826002)(101416001)(4326007)(76176999)(4001350100001)(47776003)(110136002)(2906002)(92566002)(33656002)(189998001)(11771545001)(107986001)(5001870100001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0709;H:SATLEXCHOV01.amd.com;FPR:;SPF:None;PTR:hybridsmtp.amd.com,hybridsmtp01.amd.com;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; X-MS-Office365-Filtering-Correlation-Id: 368e57fb-2cd3-45e3-1511-08d395a7b0da X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;2:2DXgeITLBtls5IHUuQ4nikmkwE5uX2PhvDwZ+N+Q5eCu2bgh1ULL1IwUeroRKSGfTNxhkFL8PHrhzGQMZ6MA7PgIMvr2g94SLjw4PAR1nYI295lAq14aQ0mlrS/dPPrHcb4cB9A6+V1Vb+IVepc4qvkOWtWj4uLiroVwDhrxSIIH5X8EDL8uuqxuqvsZY1v/;3:kYaNYU5sx5uwqzmRw+a/yeVKElkY0/J2cGmumoSQFdFLEUGLPQlvB61baP3IGr1Ts904A/LkJVYyw/Y/wdovZRG5tu+KhpnZSPuDGkG+u/PfHHyCdir82vCvH9zDAMwc+SGkEe+I5N3fkntCpSR5YFdZxb8TTgLJIELlUOLvZFs5hvS8OaIEemJpQGIncnCYYH93uo5BA5wpXWzg5VF59Sp0fR/SIy5Con2pHawxMeI=;25:CvXJ0Jbr21rEqr5Js1E9xaCT73Jsfcrb7QpVZgRgEBCNlxsGm4JQQxd6geNycaTjWCZFDKM2ql79nhl2LnS6XGGFvbcErdyI9RmXG40MvKRhFncRSQiVwe62V3JVEmrjR3mTge/KV3vclSo0KTTsBNi5qq6spQwGTQKzTN+Gjupg2toQ/402LpgLrQ7PRlowTdbu9yb0VEXL+3UWCCfY58SIk+oYDi7VLusDHxgr8EU+Z4t0rhGwKU1Saq0SW3tpQPn9bOQ9+eJKfP8DczCrSGeDaCn/aZ8vc9XEQ6mmsTocFsQ26s7aHZXn++GpzuX8mbSVuzXB0ChTz2y7eLDY6HkI8BsT9drROUAwJJDB9Kr20LjfmaF0uP9jkBF5KVsXxzrY3QI99mqZW4tcsikPmFzZN8sQAfw5L9VTNByIknE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0709; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;20:NMUqfNF8gGWIzN/ZkQsxoGWVeMwj46MX77eAsDKsHBpwmoW+j5Jf+nSsX6UsiMZdS/cfYFZF3PSjcuZNIWj3cvuDyBasPsePff2Y0OluWvuTF8WZZTVXXH0QLDhEUzc6UItRwsVUrSXWYOnMxXkMCVWoxvYOuOMKXX3imHUW/5gcnxZudcwDJ5mJ6Nz5b0kxjwB7Qh8c5fbrQMCSxFh9bHEcHdBAdBckWr+mUMn//uJeKDMuuDT7TSVid2CgdtcSdsO+TLAta2mthE8TypAyxPHy9zaNhufGkfm+tFlrSDcY09RxH4fX6GmvjvNtZALDSLFwWkuZg8DJ8hEeLixFge+7AIqS1h4W6nmKD7ZpjyFN1I5h1ph8pooiniAigq4xZNEGHPYbuRZmrjWw61qISgWuBc8wBJS97lX8F0pEGxYuirpRmyzDIKMZn8pCagExDsC+sywqSXafxdnzusLMWQBHCh8pK1WPQCD/OnyOGZUjILIBf7RgiLLXod6eDmRt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13013025)(5005006)(13021025)(8121501046)(13023025)(10201501046)(3002001)(6055026);SRVR:BY2PR12MB0709;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0709; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;4:v5iRI300FAADhIuTui0e0hMi8xDm+6lk01m1TC9mCrs4FNAmW5klGNvOoy621U5RMXnLV3G5dNnCexZmvMYm7zaZut8OCeNCCXMRSYq7NK9KxQMGRofTxQh6wlhWt7A4myXCY3px1vSA1hip5vLJ01MlFOn/217pLl4h7N51vxcX8SsqBa4ijZw9mLrq5QFGu0ciizeVyeia3PBK9n/g7S3UVsfBypXEYp53J4USSkGjWhMFQFsMlERHNijbk0qIJhPPh8kKvAxBBPYS16lO3FMcLto4YQEHbJ8Bsr8vsY9BNnEWu1juEe4LBXFDYC0aL1HIVg36xqBaGFtUpCqbRQUWb0FhqMYDxMDgpMVfZ55lyrRgsdL5WvX1gT7/WAvfV1Zm98BYpx8HxIr3Bo5AdrBY5GMNJ5TeX6SCVnUmdSEL6lsbgQdYwm9OEonSnDMZ+OoJ88yc0ifeZm5It+lnwSIY/WdgAV+3ROKv22QUuqc= X-Forefront-PRVS: 09752BC779 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR12MB0709;23:6Jddv3/GGArnZfIUInatlm25TPFgAQy+EEysk0bOY?= =?us-ascii?Q?Snq9rIUFeBOUuoMg3pNiUSEP2xrAPOloWyjCywYTZr2mu4ItL+73y7jNpYL+?= =?us-ascii?Q?xxVsUmHnN12pvT6ihmxrd/ZArFPTqxYafUK5Z+lCXkc8bVPoyT+1JLD0ufsy?= =?us-ascii?Q?hLJFfQacRp+PJLw508vYEa6as4KiQAw9Gb0BFmZKXe8/O4SABDeNhPuHtUEG?= =?us-ascii?Q?Gb/L2BKejHmyXc+7Zu4H7aGyylS4BTX518cKb4w3dFChuByINREJBOXXjpXf?= =?us-ascii?Q?OL7JOC0ovA4UnrUpFSwJ4CMbEx36wfXBAgzpi+8gD6tOM2yK0fuETdVmx/iY?= =?us-ascii?Q?fcEnsRUKiIYSb5/sFRDg4Itk1u7v09lVno2Gr7QMhGdUPNgPthD4SpoIuwsj?= =?us-ascii?Q?SamihzzzISXI10oiBy20r8A+TNOy7bY+cic7Imb9XPgM3wvET96b4IgGqF7Y?= =?us-ascii?Q?9WO/5wy+wzwBIoLV3H4knOtI9kdgJvQ/LNRbebY5XeI5YD8Pp5PZSK33PJi5?= =?us-ascii?Q?0ax3TUyIp///avR7BS1oJg8hrg2neJ/BZRAi68kijFE8LRZAnCMddBzsZpeJ?= =?us-ascii?Q?S0I5AK6OvG7d+3RF1btKNyPntBvgrfHL1M97c4Bc4QGEYTGoxNAUisl07eiC?= =?us-ascii?Q?hlrBYZifF7Odov6vMRY3of9UYHByIRBHWDgaRNfm9f6HDVUFG8sYDVkvGEVe?= =?us-ascii?Q?ZItqOTe1vquq8/c9bPdsQI1uC53jjalgIlrT6Ugi4DnELYjXU9cmCYExNhLj?= =?us-ascii?Q?46SCtNFhvmlVDzqiabCuByf/eP3I5VkLT68pkV9MRx+C2MFovSOWAQ1N9LCK?= =?us-ascii?Q?wqkE+rVfVxjb7AOmvmJCO1AhNYB5x4ZaK74Bq0FlCTJnFXeJMBRkcst5jnxz?= =?us-ascii?Q?fdO8weq744QW5HEEvW8ecwKQtio1BymS9aVlw1wBDevLQX2ZJr48s/wYpJUK?= =?us-ascii?Q?QKUgSbJSvyhSSWsnRkJgjrRM/whYGQPazdWTpc/7YyG87ks1yLJLWkXOGtiw?= =?us-ascii?Q?gVxzhxaiRLRdzhPltj1j5XquVoSiwdTFTuGbPOeWFFRT6EJhQalmYn3pv9/j?= =?us-ascii?Q?OIMMhrkA5Egkqs2BaRCUHaHvnise+Dz2yO4YoPSozjHQo5C8GwTJJHsp8mxF?= =?us-ascii?Q?rFV4lNTqbQSW9X28MGf7PBJfLjJ+wv3dS9wWZgsdagSZXN6Trey11aQCKTkx?= =?us-ascii?Q?OmCx05bpwd3caF18Y/LuM0qn6l4XCe0MPME?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;6:VI3qVdqGmiEhO26gFLHjwVnQ9tKGRAdFy9TRvr8vho/vLtDM4V9xp+z+c7z9Myv6AmWkoN3Jtu0n5yPC11FVqyP8NORY7yRjgY4CtBZwhxrnek47bdIpsyEw7nhz1lLrm4nlMNCXPNaQZeYeZWTz+WszNbKsQr7NCb5ZbBbill200DShhOzSaMSSody3vZVAQRS9BxIslzLex+KqcsQd8tKAhkPwv/kTjjodaZOm5Oj5oma9au7H73Vo/UpiW8JzvVXFWul628lMDga1ql0vq3aTsobQOgf003MzRteR8ymSMjKzbftLeHRVaRVKsF7G;5:e6V5xz6mKSvswjSKsvdh7uq3xS0EcPRJjqjEVY8rmYRFm4FlBG+2XYpTeOJnkICryqi2yljq8C2mpis4gtLrl6fsKx8f5lz5wZPBZ3eWyHUM2w5oO24D9TLheidoeKH6gNzp2MYrlJ163u4r8URUPg==;24:A38pzn/RUdN3moH4t6Qdq5ioVi1RvBNkVozPX/c9w6ur5byVV4DOG7ewHtrVawcHB6QS14IPvOqgegM4bce6gWn4mhOKZb7M+XMnFF0R2+k=;7:rMu39SxO/gwJIciMLQNOviMRCx4q0Aemg0DBsyK/Pq6a/JTBC4j94cQ3itzbJcdoMxpl1G4Dt02S0NclYqTx5vTSiJ6LE39WIomhWzmNzm/hwfblkpMfvcAPnIKJnBlqu4VAoGvlrETOD4eqe6pT1/um0heyJlGIHQ7pw0ZQJRDr5NvFbO5U3/SzALjNIEbbfV5GhOfIKydPnMk62FhLSA== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;20:hfgK3W1htVrd9hdbeczbY3MgA+eSMHzwecdIpRigK3hRWOB0m5mtvEhl7OE0PR4mUKk3M6CjOgQBkwU4EzRiInx0QNWLq4Y7vhV9jQ8xuP7XtyeXN/kxXngUoon6EeHrbhXa6E/GWKE3hOd6MxIdl5vabqoW8MSOayPcooO/DbkI66AJKBciH68cQmAE/mkSFmTzojTmzAekghfY9eySlsfQQPT7OAk/cm4j4DQjMz+JId5lVtep39bX2kqKZ8q7 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 05:33:04.2123 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.21];Helo=[SATLEXCHOV01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0709 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vince, Thanks for asking. On Wed, Jun 15, 2016 at 09:13:59PM -0400, Vince Weaver wrote: > > three questions about this functionality: > > 1. In theory this should also work on an amd fam16h model 30h > processor too, correct? The current code limits things to fam15h > even though the fam16mod30h has all the proper cpuid flags. > I was told this feature would be supported on fam15h 60h, 70h and later processors before. Just checked the fam16h model 30h BKDG, yes, it should be also supported. But I didn't test that platform, if you confirm it works in your side. We can enable it. > I've tested the functionality a bit and it seems to work but for > some reason the ptsc seems to occasionally count backwards > on my machine. Any reason that would be? (It doesn't seem to be > an overflow, just reading the ptsc 5ms apart and the values are > slightly lower after than before). > PTSC's frequency is about 100Mhz, it shouldn't be overflow. > 2. Unless I'm misunderstanding things, the code seems to be accumulating > Power. (see chunk below) Power is an instantaneous measurement, it > makes no sense to add values. If you use 5W for 1ms and 10W for > 1ms, the average power across the 2ms interval is not 15W. > > You can add energy, but not power. > > > + delta *= cpu_pwr_sample_ratio * 1000; > > + tdelta = new_ptsc - prev_ptsc; > > + > > + do_div(delta, tdelta); > > + local64_add(delta, &event->count); > You're right. Nice catch! The average power is per compute unit. We cannot add the power simplely for each processor/package. So here, the average power per package should be (delta1 + delta2 + ... + deltaN)/(tdelta_avg). I will work out a fix. Thanks to point out. > 3. The actual results gathered seem rediculously low. 341 seconds of > calculation and only using 183 mWatts of power? > mWatts are for processor power not system power. Below data is calculated on fam15h model 60h which is low power platform. Even though the method has a minor mistake, the processor power should be in mWatts field. > > Performance counter stats for 'system wide': > > > > 183.44 mWatts power/power-pkg/ > > > > 341.837270111 seconds time elapsed > > > > root@hr-zp:/home/ray/tip# ./tools/perf/perf stat -a -e 'power/power-pkg/' sleep 10 > Thanks, Rui