linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: sunxi: remove unused variable
@ 2016-06-15 15:55 Arnd Bergmann
  2016-06-16  7:18 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-06-15 15:55 UTC (permalink / raw)
  To: Emilio López
  Cc: Arnd Bergmann, Michael Turquette, Stephen Boyd, Maxime Ripard,
	Chen-Yu Tsai, linux-clk, linux-arm-kernel, linux-kernel

The only use of the local num_parents variable was remove,
so we now get a warning:

drivers/clk/sunxi/clk-sun4i-tcon-ch1.c: In function 'tcon_ch1_get_parent':
drivers/clk/sunxi/clk-sun4i-tcon-ch1.c:82:6: error: unused variable 'num_parents' [-Werror=unused-variable]

This removes the variable.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4de2d58bc973 ("clk: sunxi: tcon-ch1: Do not return a negative error in get_parent")
---
 drivers/clk/sunxi/clk-sun4i-tcon-ch1.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/sunxi/clk-sun4i-tcon-ch1.c b/drivers/clk/sunxi/clk-sun4i-tcon-ch1.c
index 248585238b1c..b6d29d1bedca 100644
--- a/drivers/clk/sunxi/clk-sun4i-tcon-ch1.c
+++ b/drivers/clk/sunxi/clk-sun4i-tcon-ch1.c
@@ -79,7 +79,6 @@ static int tcon_ch1_is_enabled(struct clk_hw *hw)
 static u8 tcon_ch1_get_parent(struct clk_hw *hw)
 {
 	struct tcon_ch1_clk *tclk = hw_to_tclk(hw);
-	int num_parents = clk_hw_get_num_parents(hw);
 	u32 reg;
 
 	reg = readl(tclk->reg) >> TCON_CH1_SCLK2_MUX_SHIFT;
-- 
2.9.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: sunxi: remove unused variable
  2016-06-15 15:55 [PATCH] clk: sunxi: remove unused variable Arnd Bergmann
@ 2016-06-16  7:18 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2016-06-16  7:18 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Emilio López, Michael Turquette, Stephen Boyd, Chen-Yu Tsai,
	linux-clk, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

On Wed, Jun 15, 2016 at 05:55:23PM +0200, Arnd Bergmann wrote:
> The only use of the local num_parents variable was remove,
> so we now get a warning:
> 
> drivers/clk/sunxi/clk-sun4i-tcon-ch1.c: In function 'tcon_ch1_get_parent':
> drivers/clk/sunxi/clk-sun4i-tcon-ch1.c:82:6: error: unused variable 'num_parents' [-Werror=unused-variable]
> 
> This removes the variable.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4de2d58bc973 ("clk: sunxi: tcon-ch1: Do not return a negative error in get_parent")

Applied, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-16  7:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-15 15:55 [PATCH] clk: sunxi: remove unused variable Arnd Bergmann
2016-06-16  7:18 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).