From: Lee Jones <lee.jones@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Brown <broonie@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
rtc-linux@googlegroups.com,
linux-kernel <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 03/10] mfd: ac100: Add driver for X-Powers AC100 audio codec / RTC combo IC
Date: Thu, 16 Jun 2016 11:32:24 +0100 [thread overview]
Message-ID: <20160616103224.GQ4948@dell> (raw)
In-Reply-To: <CAGb2v669g6G4aK5UssyLLve1a-AbdVfo4CPYrt+YWmCUURz9qQ@mail.gmail.com>
On Wed, 15 Jun 2016, Chen-Yu Tsai wrote:
> On Wed, Jun 15, 2016 at 8:36 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 15 Jun 2016, Chen-Yu Tsai wrote:
> >
> >> The AC100 is a multifunction device with an audio codec subsystem and
> >> an RTC subsystem. These two subsystems share a common register space
> >> and host interface.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >
> > Change log?
>
> Change log was in the cover letter. Changes were the addition of the
> codec related register macros and regmap ranges.
Patch specific change logs are more helpful.
> >> drivers/mfd/Kconfig | 10 +++
> >> drivers/mfd/Makefile | 2 +
> >> drivers/mfd/ac100.c | 135 +++++++++++++++++++++++++++++++++++
> >> include/linux/mfd/ac100.h | 176 ++++++++++++++++++++++++++++++++++++++++++++++
> >> 4 files changed, 323 insertions(+)
> >> create mode 100644 drivers/mfd/ac100.c
> >> create mode 100644 include/linux/mfd/ac100.h
> >>
> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> >> index 1bcf601de5bc..bd83849a0c8d 100644
> >> --- a/drivers/mfd/Kconfig
> >> +++ b/drivers/mfd/Kconfig
> >> @@ -101,6 +101,16 @@ config MFD_BCM590XX
> >> help
> >> Support for the BCM590xx PMUs from Broadcom
> >>
> >> +config MFD_AC100
> >> + tristate "X-Powers AC100"
> >> + select MFD_CORE
> >> + depends on SUNXI_RSB
> >> + help
> >> + If you say Y here you get support for the X-Powers AC100 audio codec
> >> + IC.
> >> + This driver include only the core APIs. You have to select individual
> >> + components like codecs or RTC under the corresponding menus.
> >> +
> >> config MFD_AXP20X
> >> tristate
> >> select MFD_CORE
> >> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> >> index 42a66e19e191..60f9a6b0557c 100644
> >> --- a/drivers/mfd/Makefile
> >> +++ b/drivers/mfd/Makefile
> >> @@ -113,6 +113,8 @@ obj-$(CONFIG_PMIC_DA9052) += da9052-irq.o
> >> obj-$(CONFIG_PMIC_DA9052) += da9052-core.o
> >> obj-$(CONFIG_MFD_DA9052_SPI) += da9052-spi.o
> >> obj-$(CONFIG_MFD_DA9052_I2C) += da9052-i2c.o
> >> +
> >> +obj-$(CONFIG_MFD_AC100) += ac100.o
> >> obj-$(CONFIG_MFD_AXP20X) += axp20x.o
> >> obj-$(CONFIG_MFD_AXP20X_I2C) += axp20x-i2c.o
> >> obj-$(CONFIG_MFD_AXP20X_RSB) += axp20x-rsb.o
> >> diff --git a/drivers/mfd/ac100.c b/drivers/mfd/ac100.c
> >> new file mode 100644
> >> index 000000000000..15d24fa77771
> >> --- /dev/null
> >> +++ b/drivers/mfd/ac100.c
> >> @@ -0,0 +1,135 @@
> >> +/*
> >> + * ac100.c - MFD core driver for X-Powers' AC100 Audio Codec IC
> >
> > Nit: Drop the filename here.
> >
> > Apart from that:
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Thanks.
> ChenYu
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-06-16 10:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 10:27 [PATCH v2 00/10] mfd: ac100: Add support for X-Powers AC100 audio codec / RTC combo IC Chen-Yu Tsai
2016-06-15 10:27 ` [PATCH v2 01/10] regmap: Support bulk writes for devices without raw formatting Chen-Yu Tsai
2016-06-15 10:27 ` [PATCH v2 02/10] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC combo IC Chen-Yu Tsai
2016-06-15 12:49 ` Lee Jones
2016-06-15 13:17 ` Chen-Yu Tsai
2016-06-19 14:34 ` Rob Herring
2016-06-15 10:27 ` [PATCH v2 03/10] mfd: ac100: Add driver for X-Powers AC100 audio codec / RTC " Chen-Yu Tsai
2016-06-15 12:36 ` Lee Jones
2016-06-15 12:41 ` Chen-Yu Tsai
2016-06-16 10:32 ` Lee Jones [this message]
2016-06-15 10:27 ` [PATCH v2 04/10] rtc: ac100: Add RTC driver for X-Powers AC100 Chen-Yu Tsai
2016-06-15 10:27 ` [PATCH v2 05/10] rtc: ac100: Add clk output support Chen-Yu Tsai
2016-06-15 10:27 ` [PATCH v2 06/10] ARM: dts: sun9i: a80-optimus: Add device node for AC100 Chen-Yu Tsai
2016-06-15 10:27 ` [PATCH v2 07/10] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-06-15 10:27 ` [PATCH v2 08/10] ARM: dts: sun9i: cubieboard4: Order nodes by alphabetical order Chen-Yu Tsai
2016-06-16 8:14 ` Maxime Ripard
2016-06-15 10:27 ` [PATCH v2 09/10] ARM: dts: sun9i: a80-optimus: " Chen-Yu Tsai
2016-06-16 8:14 ` Maxime Ripard
2016-06-15 10:27 ` [PATCH v2 10/10] ARM: dts: sun9i: Switch to the AC100 RTC clock outputs for osc32k Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616103224.GQ4948@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).