From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754876AbcFPOVs (ORCPT ); Thu, 16 Jun 2016 10:21:48 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:35008 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbcFPOVq (ORCPT ); Thu, 16 Jun 2016 10:21:46 -0400 Date: Thu, 16 Jun 2016 15:22:22 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Chanwoo Choi Subject: Re: [RESEND RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module Message-ID: <20160616142222.GW4948@dell> References: <1464280340-13228-1-git-send-email-javier@osg.samsung.com> <1464280340-13228-3-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1464280340-13228-3-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 May 2016, Javier Martinez Canillas wrote: > The driver's Kconfig symbol is a boolean but nothing prevents the driver > to be built as a module instead of built-in. It is true that most system > integrators will choose the latter but the config should not restrict it. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index a49565cc1a6b..33d112f390fe 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -514,8 +514,8 @@ config MFD_88PM860X > battery-charger under the corresponding menus. > > config MFD_MAX14577 > - bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" > - depends on I2C=y > + tristate "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" > + depends on I2C > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog